You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 14:59:55 UTC
[GitHub] [airflow] ishiis opened a new pull request, #24347: Add salesforce_default to List Connection
ishiis opened a new pull request, #24347:
URL: https://github.com/apache/airflow/pull/24347
closes: #24346
related: #24346
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ishiis commented on a diff in pull request #24347: Add salesforce_default to List Connection
Posted by GitBox <gi...@apache.org>.
ishiis commented on code in PR #24347:
URL: https://github.com/apache/airflow/pull/24347#discussion_r894403626
##########
airflow/utils/db.py:
##########
@@ -533,6 +533,13 @@ def create_default_connections(session: Session = NEW_SESSION):
),
session,
)
+ merge_conn(
+ Connection(
+ conn_id="salesforce_default",
+ conn_type="salesforce",
Review Comment:
I have fixed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a diff in pull request #24347: Add salesforce_default to List Connection
Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #24347:
URL: https://github.com/apache/airflow/pull/24347#discussion_r893773031
##########
airflow/utils/db.py:
##########
@@ -533,6 +533,13 @@ def create_default_connections(session: Session = NEW_SESSION):
),
session,
)
+ merge_conn(
+ Connection(
+ conn_id="salesforce_default",
+ conn_type="salesforce",
Review Comment:
I think it would be really nice to have some connection attributes filled in (even with bogus values like the others here) for what _could_ be a "useful" example connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24347: Add salesforce_default to List Connection
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24347:
URL: https://github.com/apache/airflow/pull/24347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24347: Add salesforce_default to List Connection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24347:
URL: https://github.com/apache/airflow/pull/24347#issuecomment-1154221007
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org