[GitHub] [ozone] hemantk-12 commented on a diff in pull request #3985: HDDS-7484. Snapshot ID on followers should match the one on the OM Leader

[GitBox <gi...@apache.org>]

hemantk-12 commented on code in PR #3985:
URL: https://github.com/apache/ozone/pull/3985#discussion_r1035310269


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -143,67 +147,67 @@ public OMResponse submitRequest(RpcController controller,
       throw new ServiceException(e);
     }
 
-    OMResponse response = 
-        dispatcher.processRequest(validatedRequest, this::processRequest,
-        request.getCmdType(), request.getTraceID());
-    
+    OMResponse response = dispatcher.processRequest(validatedRequest,
+        this::processRequest,
+        request.getCmdType(),
+        request.getTraceID());
+
     return requestValidations.validateResponse(request, response);
   }
 
-  private OMResponse processRequest(OMRequest request) throws
-      ServiceException {
+  private OMResponse processRequest(OMRequest request) throws ServiceException {
     OMClientRequest omClientRequest = null;
-
     boolean s3Auth = false;
+
     try {
+      if (request.getCmdType() == CreateSnapshot) {

Review Comment:
   Initially I thought about passing `SnapshotID` from client. Then I released that clients can override it and pass non-unique (random/same) SnapshotID. Let me know if clients can't override it or are not supposed to do so. If so, we can pass `SnapshotID` from client.  Otherwise I'll create separate function for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org