You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Héctor A <ne...@gmail.com> on 2015/03/28 01:22:18 UTC
[jira] (FLEX-33155)
It would be nice if somebody could check if the submitted patch is valid.
It's a longtime issue affecting many users, and it's a shame that the
contributor of the patch has been ignored.
>From what I read here <http://silight.hatenablog.jp/entry/2014/09/21/231123>
, this block of code
<https://github.com/apache/flex-sdk/blob/develop/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java#L307>
is
causing the problem as there are times where both
swcScript1CompilationUnit.hasTypeInfo and
swcScript2CompilationUnit.hasTypeInfo are true causing both
compare(swcScript1, swcScript2) and compare(swcScript2, swcScript1) to be <
0, which is not valid in a Sort method in Java 1.7.
[jira] (FLEX-33155)
Posted by Héctor A <ne...@gmail.com>.
Sorry, I haven't seen the issue myself either, I have Java 6 in all my work
machines. I've just got several reports from users in the past, in most
cases the problem showed up in big projects with several source paths
and/or libraries.
2015年3月30日月曜日、Darrell Loverin<darrell.loverin@gmail.com
<javascript:_e(%7B%7D,'cvml','darrell.loverin@gmail.com');>>さんは書きました:
> Was unable to reproduce the issue from the command line (no FB license on
> my machine), I removed the workaround from the mxmlc script (
> "-Djava.util.Arrays.useLegacyMergeSort=true") and set
> -incremental=true.
>
> Will try a few more things this coming week.
>
> If you have a reproducible scenario from the command line please let me
> know.
>
>
> -Darrell
>
> On Fri, Mar 27, 2015 at 9:05 PM, Héctor A <ne...@gmail.com> wrote:
>
> > That would be great. Thank you.
> >
> > On Sat, Mar 28, 2015 at 1:54 AM, Darrell Loverin <
> > darrell.loverin@gmail.com>
> > wrote:
> >
> > > I used to be familiar with that code. I'll take a look at the patch
> this
> > > weekend.
> > >
> > > -Darrell
> > >
> > > On Friday, March 27, 2015, Héctor A <ne...@gmail.com> wrote:
> > >
> > > > It would be nice if somebody could check if the submitted patch is
> > valid.
> > > > It's a longtime issue affecting many users, and it's a shame that the
> > > > contributor of the patch has been ignored.
> > > >
> > > > From what I read here <
> > > > http://silight.hatenablog.jp/entry/2014/09/21/231123>
> > > > , this block of code
> > > > <
> > > >
> > >
> >
> https://github.com/apache/flex-sdk/blob/develop/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java#L307
> > > > >
> > > > is
> > > > causing the problem as there are times where both
> > > > swcScript1CompilationUnit.hasTypeInfo and
> > > > swcScript2CompilationUnit.hasTypeInfo are true causing both
> > > > compare(swcScript1, swcScript2) and compare(swcScript2, swcScript1)
> to
> > > be <
> > > > 0, which is not valid in a Sort method in Java 1.7.
> > > >
> > >
> >
>
Re: [jira] (FLEX-33155)
Posted by Darrell Loverin <da...@gmail.com>.
Was unable to reproduce the issue from the command line (no FB license on
my machine), I removed the workaround from the mxmlc script (
"-Djava.util.Arrays.useLegacyMergeSort=true") and set
-incremental=true.
Will try a few more things this coming week.
If you have a reproducible scenario from the command line please let me
know.
-Darrell
On Fri, Mar 27, 2015 at 9:05 PM, Héctor A <ne...@gmail.com> wrote:
> That would be great. Thank you.
>
> On Sat, Mar 28, 2015 at 1:54 AM, Darrell Loverin <
> darrell.loverin@gmail.com>
> wrote:
>
> > I used to be familiar with that code. I'll take a look at the patch this
> > weekend.
> >
> > -Darrell
> >
> > On Friday, March 27, 2015, Héctor A <ne...@gmail.com> wrote:
> >
> > > It would be nice if somebody could check if the submitted patch is
> valid.
> > > It's a longtime issue affecting many users, and it's a shame that the
> > > contributor of the patch has been ignored.
> > >
> > > From what I read here <
> > > http://silight.hatenablog.jp/entry/2014/09/21/231123>
> > > , this block of code
> > > <
> > >
> >
> https://github.com/apache/flex-sdk/blob/develop/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java#L307
> > > >
> > > is
> > > causing the problem as there are times where both
> > > swcScript1CompilationUnit.hasTypeInfo and
> > > swcScript2CompilationUnit.hasTypeInfo are true causing both
> > > compare(swcScript1, swcScript2) and compare(swcScript2, swcScript1) to
> > be <
> > > 0, which is not valid in a Sort method in Java 1.7.
> > >
> >
>
Re: [jira] (FLEX-33155)
Posted by Héctor A <ne...@gmail.com>.
That would be great. Thank you.
On Sat, Mar 28, 2015 at 1:54 AM, Darrell Loverin <da...@gmail.com>
wrote:
> I used to be familiar with that code. I'll take a look at the patch this
> weekend.
>
> -Darrell
>
> On Friday, March 27, 2015, Héctor A <ne...@gmail.com> wrote:
>
> > It would be nice if somebody could check if the submitted patch is valid.
> > It's a longtime issue affecting many users, and it's a shame that the
> > contributor of the patch has been ignored.
> >
> > From what I read here <
> > http://silight.hatenablog.jp/entry/2014/09/21/231123>
> > , this block of code
> > <
> >
> https://github.com/apache/flex-sdk/blob/develop/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java#L307
> > >
> > is
> > causing the problem as there are times where both
> > swcScript1CompilationUnit.hasTypeInfo and
> > swcScript2CompilationUnit.hasTypeInfo are true causing both
> > compare(swcScript1, swcScript2) and compare(swcScript2, swcScript1) to
> be <
> > 0, which is not valid in a Sort method in Java 1.7.
> >
>
Re: [jira] (FLEX-33155)
Posted by Darrell Loverin <da...@gmail.com>.
I used to be familiar with that code. I'll take a look at the patch this
weekend.
-Darrell
On Friday, March 27, 2015, Héctor A <ne...@gmail.com> wrote:
> It would be nice if somebody could check if the submitted patch is valid.
> It's a longtime issue affecting many users, and it's a shame that the
> contributor of the patch has been ignored.
>
> From what I read here <
> http://silight.hatenablog.jp/entry/2014/09/21/231123>
> , this block of code
> <
> https://github.com/apache/flex-sdk/blob/develop/modules/compiler/src/java/flex2/compiler/swc/SwcGroup.java#L307
> >
> is
> causing the problem as there are times where both
> swcScript1CompilationUnit.hasTypeInfo and
> swcScript2CompilationUnit.hasTypeInfo are true causing both
> compare(swcScript1, swcScript2) and compare(swcScript2, swcScript1) to be <
> 0, which is not valid in a Sort method in Java 1.7.
>