[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1063: HDDS-1775. Make OM KeyDeletingService compatible with HA model

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1063: HDDS-1775. Make OM KeyDeletingService compatible with HA model
URL: https://github.com/apache/hadoop/pull/1063#discussion_r303616702
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyDeletingService.java
 ##########
 @@ -101,6 +112,21 @@ public BackgroundTaskQueue getTasks() {
     return queue;
   }
 
+  private boolean shouldRun() {
+    if (ozoneManager == null) {
+      // OzoneManager can be null for testing
+      return true;
 
 Review comment:
   By using Java8 method reference, we can remove this, and have a direct check of the method reference instead of calling this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org