You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/04/10 23:25:05 UTC

[GitHub] [spark] wangyum opened a new pull request, #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE

wangyum opened a new pull request, #40731:
URL: https://github.com/apache/spark/pull/40731

   ### What changes were proposed in this pull request?
   
   This PR adds `CoalesceBucketsInJoin` to `AdaptiveSparkPlanExec.queryStagePreparationRules`.
   
   ### Why are the changes needed?
   
   Coalesce buckets in join will not work if AQE is enabled.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum closed pull request #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE
URL: https://github.com/apache/spark/pull/40731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40731:
URL: https://github.com/apache/spark/pull/40731#issuecomment-1503436680

   there is already a PR doing the same thing: https://github.com/apache/spark/pull/40688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #40731:
URL: https://github.com/apache/spark/pull/40731#issuecomment-1503470505

   Close this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #40731: [SPARK-43087][SQL] Support coalesce buckets in join in AQE

Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #40731:
URL: https://github.com/apache/spark/pull/40731#issuecomment-1502627560

   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org