You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/05/19 16:40:08 UTC
Re: svn commit: r1124207 -
/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
Perhaps change 'svnserve -M' too, for consistency?
stefan2@apache.org wrote on Wed, May 18, 2011 at 11:53:54 -0000:
> Author: stefan2
> Date: Wed May 18 11:53:53 2011
> New Revision: 1124207
>
> URL: http://svn.apache.org/viewvc?rev=1124207&view=rev
> Log:
> Make the SVNInMemoryCacheSize mod_dav_svn module setting interpret
> its parameter value as "kB" instead of "MB". This is more in line with how
> all other Apache settings are being handled.
>
> * subversion/mod_dav_svn/mod_dav_svn.c
> (SVNInMemoryCacheSize_cmd): interpret parameter as "kB" instead of "MB"
> (cmds): update short user doc string
>
> Suggested by: ivan
>
> Modified:
> subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
>
> Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c?rev=1124207&r1=1124206&r2=1124207&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c (original)
> +++ subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c Wed May 18 11:53:53 2011
> @@ -437,7 +437,7 @@ SVNInMemoryCacheSize_cmd(cmd_parms *cmd,
> return "Invalid decimal number for the SVN cache size.";
> }
>
> - settings.cache_size = value * 0x100000;
> + settings.cache_size = value * 0x400;
>
> svn_set_cache_config(&settings);
>
> @@ -931,8 +931,8 @@ static const command_rec cmds[] =
> /* per server */
> AP_INIT_TAKE1("SVNInMemoryCacheSize", SVNInMemoryCacheSize_cmd, NULL,
> RSRC_CONF,
> - "specifies the maximum size im MB per process of Subversion's "
> - "in-memory object cache (default value is 16; 0 deactivates "
> + "specifies the maximum size im kB per process of Subversion's "
> + "in-memory object cache (default value is 16384; 0 deactivates "
> "the cache)."),
> /* per server */
> AP_INIT_TAKE1("SVNCompressionLevel", SVNCompressionLevel_cmd, NULL,
>
>
Re: svn commit: r1124207 -
/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
Posted by Julian Foad <ju...@wandisco.com>.
Daniel Shahaf wrote:
> Perhaps change 'svnserve -M' too, for consistency?
>
> stefan2@apache.org wrote on Wed, May 18, 2011 at 11:53:54 -0000:
> > Make the SVNInMemoryCacheSize mod_dav_svn module setting interpret
> > its parameter value as "kB" instead of "MB". This is more in line with how
> > all other Apache settings are being handled.
> >
> > * subversion/mod_dav_svn/mod_dav_svn.c
> > (SVNInMemoryCacheSize_cmd): interpret parameter as "kB" instead of "MB"
> > (cmds): update short user doc string
[...]
> > Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
[...]
> > - settings.cache_size = value * 0x100000;
> > + settings.cache_size = value * 0x400;
> >
> > svn_set_cache_config(&settings);
> >
> > @@ -931,8 +931,8 @@ static const command_rec cmds[] =
> > /* per server */
> > AP_INIT_TAKE1("SVNInMemoryCacheSize", SVNInMemoryCacheSize_cmd, NULL,
> > RSRC_CONF,
> > - "specifies the maximum size im MB per process of Subversion's "
> > - "in-memory object cache (default value is 16; 0 deactivates "
> > + "specifies the maximum size im kB per process of Subversion's "
Not introduced by this patch, but: "im kB" -> "in kB".
> > + "in-memory object cache (default value is 16384; 0 deactivates "
> > "the cache)."),
- Julian
Re: svn commit: r1124207 -
/subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
Posted by Julian Foad <ju...@wandisco.com>.
Daniel Shahaf wrote:
> Perhaps change 'svnserve -M' too, for consistency?
>
> stefan2@apache.org wrote on Wed, May 18, 2011 at 11:53:54 -0000:
> > Make the SVNInMemoryCacheSize mod_dav_svn module setting interpret
> > its parameter value as "kB" instead of "MB". This is more in line with how
> > all other Apache settings are being handled.
> >
> > * subversion/mod_dav_svn/mod_dav_svn.c
> > (SVNInMemoryCacheSize_cmd): interpret parameter as "kB" instead of "MB"
> > (cmds): update short user doc string
[...]
> > Modified: subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c
[...]
> > - settings.cache_size = value * 0x100000;
> > + settings.cache_size = value * 0x400;
> >
> > svn_set_cache_config(&settings);
> >
> > @@ -931,8 +931,8 @@ static const command_rec cmds[] =
> > /* per server */
> > AP_INIT_TAKE1("SVNInMemoryCacheSize", SVNInMemoryCacheSize_cmd, NULL,
> > RSRC_CONF,
> > - "specifies the maximum size im MB per process of Subversion's "
> > - "in-memory object cache (default value is 16; 0 deactivates "
> > + "specifies the maximum size im kB per process of Subversion's "
Not introduced by this patch, but: "im kB" -> "in kB".
> > + "in-memory object cache (default value is 16384; 0 deactivates "
> > "the cache)."),
- Julian