You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/05 06:17:58 UTC

[GitHub] [incubator-echarts] pissang commented on a change in pull request #13067: Optimize: disable tooltip transition at first show

pissang commented on a change in pull request #13067:
URL: https://github.com/apache/incubator-echarts/pull/13067#discussion_r465497344



##########
File path: src/component/tooltip/TooltipHTMLContent.ts
##########
@@ -355,6 +354,7 @@ class TooltipHTMLContent {
         el.style.pointerEvents = this._enterable ? 'auto' : 'none';
 
         this._show = true;
+        this._firstShow && (this._firstShow = false);

Review comment:
       I think this condition is not necessary. The expression can be simply
   ```js
   this._show = true;
   this._firstShow = false;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org