You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "GungnirLaevatain (GitHub)" <gi...@apache.org> on 2019/12/19 03:37:55 UTC
[GitHub] [dubbo] GungnirLaevatain opened pull request #5508: Use
ReflectUtils#isPrimitives instead of JValidator#isPrimitives
## What is the purpose of the change
`JValidator#isPrimitives` is the same as `ReflectUtils#isPrimitives` , so use `ReflectUtils#isPrimitives` instead of `JValidator#isPrimitives`
## Brief changelog
`org.apache.dubbo.validation.support.jvalidation.JValidator`
## Verifying this change
pass the `JValidatorTest`
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5508 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5508: Use
ReflectUtils#isPrimitives instead of JValidator#isPrimitives
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=h1) Report
> Merging [#5508](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/1750e47c647efdeaf758bdd482f0943d1b715c80?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5508 +/- ##
============================================
+ Coverage 61.1% 61.18% +0.07%
Complexity 422 422
============================================
Files 921 922 +1
Lines 37495 37504 +9
Branches 5441 5441
============================================
+ Hits 22913 22945 +32
+ Misses 12083 12065 -18
+ Partials 2499 2494 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bbo/validation/support/jvalidation/JValidator.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci12YWxpZGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby92YWxpZGF0aW9uL3N1cHBvcnQvanZhbGlkYXRpb24vSlZhbGlkYXRvci5qYXZh) | `71.33% <0%> (+0.34%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `53.75% <0%> (-3.75%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `78.57% <0%> (-2.39%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `90.47% <0%> (-2.39%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `56.81% <0%> (-2.28%)` | `0% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `66.33% <0%> (-1.99%)` | `0% <0%> (ø)` | |
| [...g/apache/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvaHR0cC9IdHRwUHJvdG9jb2wuamF2YQ==) | `43.75% <0%> (-1.42%)` | `6% <0%> (ø)` | |
| [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `73.73% <0%> (-0.7%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `48.15% <0%> (-0.29%)` | `31% <0%> (-1%)` | |
| ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/5508/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=footer). Last update [1750e47...851f4c5](https://codecov.io/gh/apache/dubbo/pull/5508?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5508 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org