You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by chaitali <ch...@freestoneinfotech.com> on 2023/08/08 11:14:47 UTC
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
-----------------------------------------------------------
(Updated Aug. 8, 2023, 11:14 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221
Repository: atlas
Description
-------
Currently in Atlas, the collection names are not configurable
We need to provide functionality where in names of the solr collections can be customized using property configuration
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0
distro/src/bin/atlas_config.py 31e6fd043
distro/src/bin/atlas_start.py ffbe16271
distro/src/conf/atlas-application.properties b5734d7a8
distro/src/test/python/scripts/TestMetadata.py b813f927f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea
repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java PRE-CREATION
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 8a8e8cafc
Diff: https://reviews.apache.org/r/73249/diff/9/
Changes: https://reviews.apache.org/r/73249/diff/8-9/
Testing
-------
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
Thanks,
chaitali
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review225658
-----------------------------------------------------------
distro/src/bin/atlas_config.py
Lines 737 (patched)
<https://reviews.apache.org/r/73249/#comment314123>
get_solr_collection_name
distro/src/conf/atlas-application.properties
Lines 289 (patched)
<https://reviews.apache.org/r/73249/#comment314122>
#289 to #292 duplicate configs
distro/src/conf/atlas-application.properties
Lines 290 (patched)
<https://reviews.apache.org/r/73249/#comment314124>
Can you modify configs like
atlas.index.name.vertex.index=
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 82 (patched)
<https://reviews.apache.org/r/73249/#comment314125>
What error do we get, if after deploying Atlas, collection names are changed?
- Pinal Shah
On Aug. 9, 2023, 6:38 a.m., chaitali wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2023, 6:38 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently in Atlas, the collection names are not configurable
>
> We need to provide functionality where in names of the solr collections can be customized using property configuration
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0
> distro/src/bin/atlas_config.py 31e6fd043
> distro/src/bin/atlas_start.py ffbe16271
> distro/src/conf/atlas-application.properties b5734d7a8
> distro/src/test/python/scripts/TestMetadata.py b813f927f
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea
> repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java PRE-CREATION
> tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 8a8e8cafc
>
>
> Diff: https://reviews.apache.org/r/73249/diff/10/
>
>
> Testing
> -------
>
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/
>
>
> Thanks,
>
> chaitali
>
>
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable
Posted by chaitali <ch...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
-----------------------------------------------------------
(Updated Aug. 24, 2023, 9:38 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221
Repository: atlas
Description
-------
Currently in Atlas, the collection names are not configurable
We need to provide functionality where in names of the solr collections can be customized using property configuration
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0
distro/src/bin/atlas_config.py 31e6fd043
distro/src/bin/atlas_start.py ffbe16271
distro/src/conf/atlas-application.properties b5734d7a8
distro/src/test/python/scripts/TestMetadata.py b813f927f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea
repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java PRE-CREATION
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 8a8e8cafc
Diff: https://reviews.apache.org/r/73249/diff/11/
Changes: https://reviews.apache.org/r/73249/diff/10-11/
Testing
-------
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/
Thanks,
chaitali
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable
Posted by chaitali <ch...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
-----------------------------------------------------------
(Updated Aug. 9, 2023, 6:38 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221
Repository: atlas
Description
-------
Currently in Atlas, the collection names are not configurable
We need to provide functionality where in names of the solr collections can be customized using property configuration
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0
distro/src/bin/atlas_config.py 31e6fd043
distro/src/bin/atlas_start.py ffbe16271
distro/src/conf/atlas-application.properties b5734d7a8
distro/src/test/python/scripts/TestMetadata.py b813f927f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea
repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java PRE-CREATION
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 8a8e8cafc
Diff: https://reviews.apache.org/r/73249/diff/10/
Changes: https://reviews.apache.org/r/73249/diff/9-10/
Testing
-------
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/
Thanks,
chaitali
Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable
Posted by chaitali <ch...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
-----------------------------------------------------------
(Updated Aug. 8, 2023, 11:36 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221
Repository: atlas
Description
-------
Currently in Atlas, the collection names are not configurable
We need to provide functionality where in names of the solr collections can be customized using property configuration
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java c84e1b2d0
distro/src/bin/atlas_config.py 31e6fd043
distro/src/bin/atlas_start.py ffbe16271
distro/src/conf/atlas-application.properties b5734d7a8
distro/src/test/python/scripts/TestMetadata.py b813f927f
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e8c7a15ea
repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java PRE-CREATION
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 8a8e8cafc
Diff: https://reviews.apache.org/r/73249/diff/9/
Testing (updated)
-------
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1439/
Thanks,
chaitali