You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Peter Klügl (Created JIRA)" <de...@uima.apache.org> on 2011/10/10 16:59:29 UTC
[jira] [Created] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Migrate TextMarker visualization to CAS Editor
----------------------------------------------
Key: UIMA-2252
URL: https://issues.apache.org/jira/browse/UIMA-2252
Project: UIMA
Issue Type: New Feature
Components: TextMarker
Reporter: Peter Klügl
Assignee: Peter Klügl
Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126496#comment-13126496 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
The Cas Editor is using ISelectionProvider and ISelectionListener to synchronize selections between different views. You also need to use this.
To register a selection listener in a view you would do a call like this:
getSite().getPage().addSelectionListener(...);
And to register the selection provider:
getSite().setSelectionProvider(...);
In the Cas Editor views usually a JFace Viewer is registered as the selection provider,
e.g. a list, table, tree, etc.
The viewer contains usually your element objects, if this is not a FeatureStructure,
you should return the FeatureStructure via getAdapter.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126495#comment-13126495 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Another quick question:
Is there an official way to get notified about a caret change?
Maybe listening to the selection changes and then Point p = AnnotationEditor.getSelection()?
Sorry for all those simple questions. I still try to get familiar with the code and I don't want to implement something parallel to the interfaces that should be used.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129808#comment-13129808 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Can we do the type system search strategy extension point in the CAS Editor thing as soon as possible? I was selecting type systems today for at least half an hour, a bit annoying. If you like I would start with this and come back to you if I encounter some problems.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126498#comment-13126498 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
As far as I know there is no way to get notified about caret position changes.
For what do you need that?
Maybe an alternative would be to listen for text selections, but the Annotation Editor would need a change to send these out. Need to investigate this a bit more.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126527#comment-13126527 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Ah ok, then the text selection event would be nice to have. I wonder how external views can create annotations without this information?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126508#comment-13126508 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Thanks for the link.
"In eclipse there is an ITextSelection, would that solve your problem?"
Always depends on what it returns in which situation. I just gonna try it and we will see.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130480#comment-13130480 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Yes, sure, you can of course do that. I will review all changes you do and give feedback.
I think the logic to search a different type system needs to be added to DefaultCasDocumentProvider.createDocument. The code there needs to find the location of the type system inside the workspace.
We still need to figure out on which type system extension will be chosen in case there are multiple. An idea was to make it dependent on the project nature, is there anything else we can use? I thought about a priority, but I am not sure if that will work well if there are really multiple plugins providing an extension.
To make it extensible we have to define an interface which user code can implement. I believe this interface should get the location of the CAS file. Then it is possible to open the CAS file in case it contains the correct type system location, Richard was suggesting something like this, where the TS is hosted on a web server and the location is stored in the CAS itself. To retrieve the location the search strategy would need to load the CAS file.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129682#comment-13129682 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Ups, it is not there. I will add it in UIMA-2265.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125746#comment-13125746 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Lets make sure we are using the same terms.
"If I check a type e.g., in the Annotation Styles view, then all annotations of the type are highlighted."
Through the Cas Editor code base this is usually called "shown" or "displayed", but never highlighted.
Selecting in the Cas Editor always means to give "focus" to something, like you give focus to an entry in a List control.
The Cas Editor currently only supports "reducing" the amount of shown annotations by enabling/disabling the types which are displayed. You would like to add an additional filter mechanism to further reduce that to a sub-set of the existing annotations, right?
Would a better selection/highlighting of multiple annotations be just as good for you?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125736#comment-13125736 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
To highlight annotations that aren't in the CAS would be also useful for the Query view, but I mean something different here.
If I check a type e.g., in the Annotation Styles view, then all annotations of the type are highlighted.
If I select an annotation in the outline view or Feature Structure view, then the single annotation is selected in the editor. But if I select another annotation, the first selection is of course gone.
What I want/need is to highlight single annotations in the CAS, e.g., that two annotation of type1 and three annotations of type2 are highlighted at the same time and only those annotations of these types. If you open a CAS with the CEV and open the Annotation Browser view, then you can expand the type nodes and select single annotations to be highlighted (and jump to it with double click).
Normally, I would say that this functionality is maybe nice to have but not essential. But in the context of the TextMarker, the explanation of the rule matches is built upon it amongst other things.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130492#comment-13130492 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
I can understand your point, but I don't see another solution and I am hoping that the constraints of the different strategies are specific enough not be applied in the the same situation. If not, then the developers of the strategies need to know of the other ones and have to fine tune their own strategies.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126514#comment-13126514 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
The Annotation Editor is not sending it our currently, we would need to change that.
It should be sent if a piece of text is selected in it, e.g. via the find dialog, shift + caret movement, double click on a word, mouse text selections, etc.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125792#comment-13125792 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
I think the explanation of the rule inference would also work fine with the focus, because normally you are only interested how the current rule is executed. The method highlight(int start, int length) is responsible for the focus? The method selectionChanged(IWorkbenchPart part, ISelection selection) only highlights the first one as I see it. I would need some interface/method to focus several annotations in the editor. Is that possible?
I don't know if it isn't faster to completely reimplement the other views like selection, because the annotation children and the feature children in the tree aren't any useful then... I have to think about that a bit more...
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125722#comment-13125722 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Not sure what you mean here. The Annotation Editor can only display annotation which are in the CAS. The annotations which are displayed are the ones of the "current mode" plus the annotations in the "shown annotation" list.
All displayed annotations can be selected. You can try this in the outline view.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126492#comment-13126492 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
A question about the focus:
How should I notify the editor about the focus?
- AnnotationEditor.setAnnotationSelection() is not visible
- FeatureStructureSelectionProvider is not visible as type
- AnnotationEditor.getSelectionProvider() returns the interface without setSelection(ICasDocument document, List<AnnotationFS> selection) and I can't cast it to FeatureStructureSelectionProvider
- so I should call AnnotationEditor.getSelectionProvider().setSelection(ISelection selection)?
The other methods would be much more convenient for me because I wouldn't have to create a structured selection.
Maybe I missed something?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125802#comment-13125802 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
We need to fix this in the Annotation Editor. Your view shouldn't call any methods on the Annotation Editor to do this. What should be done is to produce a selection event which contains multiple annotations. The Annotation Editor should then be fixed to visualize this selection correctly.
I am happy to work on this fix, I believe it is also a bit annoying when you select multiple annotations in the outline view. Do you want to open a jira?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129620#comment-13129620 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
I already had a look and only saw one view, the other two are just dummies, right?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125779#comment-13125779 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
The annotation painting code maps annotations in the CAS based on the type to eclipse annotations, the eclipse annotations are then associated with a drawing strategy.
The whole concept of the Cas Editor is focused on the CAS as its central model. So doing it as you described would be a bigger change.
Anyway back to the idea to improve the focus, you are right, if something else is selected it would loose the focus. So that will not be helpful for you.
When I think a bit more about it, it is actually for quite some cases an issue that it is so hard to "mark/select" a couple of annotations to then do something with them in the Annotation Editor.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127395#comment-13127395 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
For this a call to AnnotationEditor.getSelection() which returns a Point object which contains a text selection might already be sufficient. Anyway I hope to get the text selection issue closed soon.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130485#comment-13130485 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
I'd go for priorities defined in the extension. If a strategy is not applicable (returns null), then the strategy with the next higher priority will be asked. The strategies themselves can then check on the project nature or for a web server dependent on some preference settings. If there are multiple extension with the same priority, I would simply choose by alphabetic sorting.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130489#comment-13130489 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
For me it seems difficult to use these priorities, because two plugins made by different teams have to set the priority correctly. How do they do that?
I can see that it works nicely when you have different strategies in one plugin, like you did with CEV.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126500#comment-13126500 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
About the selection:
Ah, ok, that makes sense. Then I only have to check on the kind of SelectionEvent.
I will remove my own object structure and let the ContentProvider use the UIMA objects.
About the caret:
Normally, the selection in the editor is enough, but the selection view needs the exact position (offset) in the document in order to calculate the overlapping annotations.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129650#comment-13129650 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
There are two views (package selection and browser) that use the same implementation (package tree). Both are added to the CAS Editor category and give an overview of the types and their annotation whereby selection only displays those overlapping the the cursor location.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130491#comment-13130491 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Yes, the issue is still open. We should fix this for 2.4.0.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125723#comment-13125723 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Do you want to "select" non-existing annotations with an annotation style in the Annotation Editor?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126524#comment-13126524 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
The Annotation Editor is already sending out annotation selection events, but it does it only for the current mode it is in and not for other (also) shown annotation types.
Sending out the text selection event should not be a big deal.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124155#comment-13124155 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Lets do the following to get started:
- Create a new plugin next to the other Text Marker plugins
- Create a sub-class of the CasDocumentProvider
- Migrate the code from the CEV plugin over to the CasDocumentProvider sub-class
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125769#comment-13125769 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
"Would a better selection/highlighting of multiple annotations be just as good for you?"
This means the focus? If yes, then no: I think it would loose the focus if another annotation is selected.
I personally wouldn't use a filter mechanism, because the annotation to be shown is normally known. I'd rather add a method like editor.setShownAnnotationType() for single annotations or collections of annotations. Of course, the editor or someone needs to remember the state for the single annotations then. Also, some logic how to handle shown types and not shown annotations and similar settings need to be included.
I don't know yet how the AnnotationPainter works, so no idea if those changes are possible or a lot of work...
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125720#comment-13125720 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
I started now with the selection view, but it will take longer than expected. There are many small differences that prevent a fast migration, e.g., the generated icons of the tree.
A question: the CAS Editor only highlights all annotations of the checked type, right? The selected annotation is then also selected in the editor. So the CAS Editor can't highlight single annotations with the annotation style settings? This would be a bigger difference between CEV and CAS Editor and it's somewhat essential for some components and uses cases of the TextMarker, e.g., to show where a specific rule matched.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (UIMA-2252) Migrate TextMarker visualization to CAS
Editor
Posted by "Peter Klügl (Closed JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Klügl closed UIMA-2252.
-----------------------------
Resolution: Fixed
Closing the issue for now since most of the work is done. For remaining smaller parts and bug, new issues should be created.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124976#comment-13124976 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
For what do I need the CasDocumentProvider exactly? For the special coloring settings? I would keep the default one first and see if there are any problems.
If there are not any objections, then I start with adding the views selection, annotationBrowser, apply, element, matched, failed, fn, fp and tp. I would also migrate the annotationBrowser. We can remove it then later and an additional view in the sandbox won't be a problem for now.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129595#comment-13129595 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Jörn can you take a look at the two views I committed to uimaj-ep-textmarker-caseditor? These are the two that could maybe moved to the CAS Editor itself since they have no dependency to TextMarker.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125805#comment-13125805 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Yes, I will open one.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126520#comment-13126520 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Hmm... If you like to add that, I would be happy, but I don't know yet if the effort pays.
In the CEV, I solved it with getOffsetAtLocation(new Point(event.x, event.y)) on a mouse (down) event. So active user interaction in the editor is needed and that's fine for me (missing the other caret changes).
Overall, I just need some way for the user to point to an offset in order to retrieve the annotations there. Maybe I can already achieve that with the current interfaces and listener, so you would not have to change anything for this special case.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126504#comment-13126504 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Here is also an article which explains how it works:
http://www.eclipse.org/articles/Article-WorkbenchSelections/article.html
Usually you want to check that it is a StructuredSelection and then you might want to filter
out anything which is not an annotation, that can be done with the AnnotationSelection class,
have a quick look at it and search for a usage in the Cas Editor code base.
Can you elaborate a bit ont eh caret position. In the Annotation Editor there are also ways to select a piece of text which do not change the caret position. If you just look for caret position changes you miss these. Thats why I believe you usually want to know about the text selection (includes offsets in the editor).
In eclipse there is an ITextSelection, would that solve your problem?
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130487#comment-13130487 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
By the way, I had an exception in the CAS Editor when opening a CAS with a type system where not all types of the CAS were defined. Is that (still) normal? We already talked about it and you opened an issues, if I remember correctly.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126536#comment-13126536 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
Ok, can you open a jira for that? If you depend on the text selection, then the Annotation Editor has currently the focus, usually people prefer to directly create an annotation from it via "shift" + "enter".
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128967#comment-13128967 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
I decided to keep my own objects for the treeviewer/content provider for now, was looking for the IAdaptable stuff and found:
mNext = (FeatureStructure) ((IAdaptable) item).getAdapter(AnnotationFS.class); (FeatureStructureSelectionIterator line 58)
I was wondering about the adapter class. Why do you use AnnotationFS.class? I first used FeatureStructure in the interface implementation and that obviously didn't work then... I hope that's not a stupid question.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127373#comment-13127373 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Yes, but we have some annotation task where annotations for an ontology with more than 500 concepts are created, so modelling the ontology with types and use the default annotation functionality is inconvenient. The concept id is stored in a feature of the annotation and is too complicated to be just added as String in the Feature edit view. Our annotation task looks then like this: The user selects a text passage in the editor and then clicks on a node of the onotlogy (in fact it's a tree-like terminology) that is displayed in an additional view. Only the view knows the complete information then to create the annotation, but need to get the offests from the editor.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Joern Kottmann (Commented) (JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129664#comment-13129664 ]
Joern Kottmann commented on UIMA-2252:
--------------------------------------
I was a little confused by the SelectionViewPage and AnnotationBrowserPage, because you could just create AnnotationTreeViewPage in the way you need it from SelectionView or AnnotationBrowserView.
Looks like you should remove a couple of listeners when your page is disposed. Otherwise they could fail, e.g. TreeViewAnnotationStyleChangeListener calls treeView.refresh() which I guess might not work with a underlying disposed control.
In AnnotationTreeViewPage.annotationModeChanged you call the editor to retrieve the mode, is something wrong with the new passed mode? Should be identical to the one you get via getAnnotationMode.
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (UIMA-2252) Migrate TextMarker visualization to
CAS Editor
Posted by "Peter Klügl (Commented JIRA)" <de...@uima.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129667#comment-13129667 ]
Peter Klügl commented on UIMA-2252:
-----------------------------------
Oh yes, SelectionViewPage and AnnotationBrowserPage are remains after the refactoring. I'll remove them.
I haven't found a AnnotationEditor.removeAnnotationListener()
> Migrate TextMarker visualization to CAS Editor
> ----------------------------------------------
>
> Key: UIMA-2252
> URL: https://issues.apache.org/jira/browse/UIMA-2252
> Project: UIMA
> Issue Type: New Feature
> Components: TextMarker
> Reporter: Peter Klügl
> Assignee: Peter Klügl
>
> Start the migration of the CEV plugins of the TextMarker using the CAS Editor code base. Investigate the which changes in the CAS Editor are needed to support the existing TextMarker functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira