You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Sai Pullabhotla (JIRA)" <ji...@apache.org> on 2009/07/04 03:56:47 UTC

[jira] Created: (FTPSERVER-318) Subclasses of FtpException ignore the Throwable parameter in their constructors

Subclasses of FtpException ignore the Throwable parameter in their constructors
-------------------------------------------------------------------------------

                 Key: FTPSERVER-318
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-318
             Project: FtpServer
          Issue Type: Bug
          Components: Core, Ftplets
    Affects Versions: 1.0.2
            Reporter: Sai Pullabhotla
            Priority: Minor
             Fix For: 1.0.3


Currently there are two subclasses of FtpException - 

1) AuthenticationFailedException
2) DataConnectionException

The constructors AuthenticationFailedException(String msg, Throwable th) and DataConnectionException(final String msg, final Throwable th) ignore (do not use) the second parameter, "th". The parameter "th" should be passed to the constructor of super class to have accurate stack trace. 

Also, out of curiosity, why does the FtpException has a member variable named "throwable" for storing the cause instead of using the cause defined in java.lang.Throwable? Why were the printStackTrace methods overridden? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (FTPSERVER-318) Subclasses of FtpException ignore the Throwable parameter in their constructors

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson updated FTPSERVER-318:
----------------------------------------

    Fix Version/s: 1.1.0
         Assignee: Niklas Gustavsson

> Subclasses of FtpException ignore the Throwable parameter in their constructors
> -------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-318
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-318
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core, Ftplets
>    Affects Versions: 1.0.2
>            Reporter: Sai Pullabhotla
>            Assignee: Niklas Gustavsson
>            Priority: Minor
>             Fix For: 1.0.3, 1.1.0
>
>
> Currently there are two subclasses of FtpException - 
> 1) AuthenticationFailedException
> 2) DataConnectionException
> The constructors AuthenticationFailedException(String msg, Throwable th) and DataConnectionException(final String msg, final Throwable th) ignore (do not use) the second parameter, "th". The parameter "th" should be passed to the constructor of super class to have accurate stack trace. 
> Also, out of curiosity, why does the FtpException has a member variable named "throwable" for storing the cause instead of using the cause defined in java.lang.Throwable? Why were the printStackTrace methods overridden? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (FTPSERVER-318) Subclasses of FtpException ignore the Throwable parameter in their constructors

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson closed FTPSERVER-318.
---------------------------------------

    Resolution: Fixed

Fixed in rev 817215. Also removed the ancient handling of the causing exception and deprecated the FtpException.getRootCause() method.

> Subclasses of FtpException ignore the Throwable parameter in their constructors
> -------------------------------------------------------------------------------
>
>                 Key: FTPSERVER-318
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-318
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core, Ftplets
>    Affects Versions: 1.0.2
>            Reporter: Sai Pullabhotla
>            Assignee: Niklas Gustavsson
>            Priority: Minor
>             Fix For: 1.0.3, 1.1.0
>
>
> Currently there are two subclasses of FtpException - 
> 1) AuthenticationFailedException
> 2) DataConnectionException
> The constructors AuthenticationFailedException(String msg, Throwable th) and DataConnectionException(final String msg, final Throwable th) ignore (do not use) the second parameter, "th". The parameter "th" should be passed to the constructor of super class to have accurate stack trace. 
> Also, out of curiosity, why does the FtpException has a member variable named "throwable" for storing the cause instead of using the cause defined in java.lang.Throwable? Why were the printStackTrace methods overridden? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.