You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/07 21:18:55 UTC

[GitHub] [beam] robertwb commented on a diff in pull request #17773: [BEAM-14524] Add return_row option to RunInference transform

robertwb commented on code in PR #17773:
URL: https://github.com/apache/beam/pull/17773#discussion_r891718388


##########
sdks/python/apache_beam/ml/inference/api.py:
##########
@@ -52,8 +52,12 @@ class RunInference(beam.PTransform):
 
   TODO(BEAM-14046): Add and link to help documentation
   """
-  def __init__(self, model_loader: base.ModelLoader):
-    self._model_loader = model_loader
+  def __init__(
+      self, model_loader: Union[base.ModelLoader, Callable], return_row=False):

Review Comment:
   As per the discussion, the returned PredictionResult will always be row-compatible rather than requiring an option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org