You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by ju...@apache.org on 2025/11/21 14:20:05 UTC
(buildstream) 01/03: _loader: Drop unused dependency list
This is an automated email from the ASF dual-hosted git repository.
juergbi pushed a commit to branch jbilleter/links
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 4392664c500364a5850fe16ce6dd8facbf6e6854
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Fri Nov 21 14:55:30 2025 +0100
_loader: Drop unused dependency list
---
src/buildstream/_loader/loader.py | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/buildstream/_loader/loader.py b/src/buildstream/_loader/loader.py
index b36dfe068..42a7eb4a4 100644
--- a/src/buildstream/_loader/loader.py
+++ b/src/buildstream/_loader/loader.py
@@ -495,8 +495,7 @@ class Loader:
# The loader queue is a stack of tuples
# [0] is the LoadElement instance
# [1] is a stack of Dependency objects to load
- # [2] is a list of dependency names used to warn when all deps are loaded
- loader_queue = [(top_element, list(reversed(dependencies)), [])]
+ loader_queue = [(top_element, list(reversed(dependencies)))]
# Load all dependency files for the new LoadElement
while loader_queue:
@@ -505,8 +504,6 @@ class Loader:
# Process the first dependency of the last loaded element
dep = current_element[1].pop()
- # And record its name for checking later
- current_element[2].append(dep.name)
if dep.junction:
loader = self.get_loader(dep.junction, dep.node)
@@ -529,7 +526,7 @@ class Loader:
dep_element.mark_fully_loaded()
dep_deps = extract_depends_from_node(dep_element.node)
- loader_queue.append((dep_element, list(reversed(dep_deps)), []))
+ loader_queue.append((dep_element, list(reversed(dep_deps))))
# Pylint is not very happy about Cython and can't understand 'node' is a 'MappingNode'
if dep_element.node.get_str(Symbol.KIND) == "junction": # pylint: disable=no-member