You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/03 14:22:38 UTC

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

PierreSmits opened a new pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383


   Though there is an entity InvoiceNote, this cannot be accessed by user with VIEW permissions when accessing an invoice.
   See:
   for entity data:https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/InvoiceNote
   test invoice: https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo11001
   
   Modified:
   AccountingMenus.xml
   - added menu-item for invoice notes to InvoiceTabBar menu, reordered menu-items alphabetically
   controller.xml
   - added request-map and view-map for request invoiceNotes
   InvoiceScreens.xml
   - added screen for invoice notes
   InvoiceForms.xml
   - added grid to display InvoiceNote records
   AccountingUiLabels.xml
   - added label for page title invoice notes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux merged pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383#issuecomment-985994899


   Good morning Jacques,
   
   Are you referring to the  alphabetically reordering of certain menu-items in the InvoiceTabBar menu? If you are, I suggest you pay attention to the first 2 lines beneath 'modified in both commit and PR message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383#issuecomment-985561515


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=383&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=383) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=383&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=383&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383#issuecomment-985988559


   Hi Pierre,
   
   It works but you forgot to (at least) mention the (right) changes in AccountingMenus::editInvoiceApplications and EditInvoiceTimeEntries. It's OK but please rather open specific issues for these kind of changes. It's much work for reviewers/committers to understand what is really done, TIA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #383: Improved: VIEW permissions - invoice notes (OFBIZ-12431)

Posted by GitBox <gi...@apache.org>.
JacquesLeRoux commented on pull request #383:
URL: https://github.com/apache/ofbiz-framework/pull/383#issuecomment-986003964


   I meant the "add"  of 
                           <if-compare field="invoice.statusId" operator="equals" value="INVOICE_SENT"/>
                           <if-compare field="invoice.statusId" operator="equals" value="INVOICE_APPROVED"/>
   But it's indeed actually the reordering that mislead me (removed on one side added to other, I used the horizontal GH review).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org