You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/16 02:54:14 UTC

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #8622: Refactor VisitorEngine

jingshanglu commented on a change in pull request #8622:
URL: https://github.com/apache/shardingsphere/pull/8622#discussion_r543859795



##########
File path: shardingsphere-infra/shardingsphere-infra-parser/src/main/java/org/apache/shardingsphere/infra/parser/sql/SQLStatementParserExecutor.java
##########
@@ -32,7 +32,7 @@
     
     public SQLStatementParserExecutor(final String databaseType) {
         parserEngine = new SQLParserEngine(databaseType);
-        visitorEngine = new SQLVisitorEngine(databaseType, "STATEMENT");
+        visitorEngine = new SQLVisitorEngine(databaseType, "STATEMENT", null);

Review comment:
       @tristaZero I think it is more user-friendly to use `null`,It is difficult to accept a new empty configuration without configuration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org