You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/19 03:23:55 UTC
[GitHub] [kafka] rondagostino commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit
rondagostino commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472636924
##########
File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -185,10 +192,9 @@ public void close() {
deleteAllTopics(backup.kafka());
primary.stop();
backup.stop();
+ assertFalse(exited.get());
Review comment:
```suggestion
assertFalse(exited.get());
Exit.resetExitProcedure();
```
##########
File path: core/src/test/scala/integration/kafka/tools/MirrorMakerIntegrationTest.scala
##########
@@ -29,14 +29,31 @@ import org.apache.kafka.clients.producer.{ProducerConfig, ProducerRecord}
import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.errors.TimeoutException
import org.apache.kafka.common.serialization.{ByteArrayDeserializer, ByteArraySerializer}
+import org.apache.kafka.common.utils.Exit
+import org.junit.After
import org.junit.Test
import org.junit.Assert._
+import org.junit.Before
class MirrorMakerIntegrationTest extends KafkaServerTestHarness {
override def generateConfigs: Seq[KafkaConfig] =
TestUtils.createBrokerConfigs(1, zkConnect).map(KafkaConfig.fromProps(_, new Properties()))
+ val exited = new AtomicBoolean(false)
+
+ @Before
+ override def setUp(): Unit = {
+ Exit.setExitProcedure((_, _) => exited.set(true))
+ super.setUp()
+ }
+
+ @After
+ override def tearDown(): Unit = {
+ super.tearDown()
+ assertFalse(exited.get())
Review comment:
```suggestion
assertFalse(exited.get())
Exit.resetExitProcedure()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org