You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2024/11/05 15:48:28 UTC

(shardingsphere) branch master updated: Refactor ShadowDMLStatementDataSourceMappingsRetriever (#33556)

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 0f6e2efe119 Refactor ShadowDMLStatementDataSourceMappingsRetriever (#33556)
0f6e2efe119 is described below

commit 0f6e2efe1194f9c6e089ca58852821fbaea4d239
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Tue Nov 5 23:48:22 2024 +0800

    Refactor ShadowDMLStatementDataSourceMappingsRetriever (#33556)
---
 .../retriever/dml/ShadowDMLStatementDataSourceMappingsRetriever.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/route/retriever/dml/ShadowDMLStatementDataSourceMappingsRetriever.java b/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/route/retriever/dml/ShadowDMLStatementDataSourceMappingsRetriever.java
index 2971b1e35c1..b42cefe8815 100644
--- a/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/route/retriever/dml/ShadowDMLStatementDataSourceMappingsRetriever.java
+++ b/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/route/retriever/dml/ShadowDMLStatementDataSourceMappingsRetriever.java
@@ -80,13 +80,13 @@ public final class ShadowDMLStatementDataSourceMappingsRetriever implements Shad
         if (queryContext.getSqlStatementContext() instanceof SelectStatementContext) {
             return new ShadowSelectStatementDataSourceMappingsRetriever((SelectStatementContext) queryContext.getSqlStatementContext(), queryContext.getParameters(), tableAliasAndNameMappings);
         }
-        throw new UnsupportedOperationException(String.format("unsupported SQL statement context `%s`", queryContext.getSqlStatementContext().getClass().getName()));
+        return null;
     }
     
     @Override
     public Map<String, String> retrieve(final ShadowRule rule) {
         Collection<String> shadowTables = rule.filterShadowTables(tableAliasAndNameMappings.values());
         Map<String, String> result = tableHintDataSourceMappingsRetriever.retrieve(rule, shadowTables);
-        return result.isEmpty() ? shadowColumnDataSourceMappingsRetriever.retrieve(rule, shadowTables) : result;
+        return result.isEmpty() && null != shadowColumnDataSourceMappingsRetriever ? shadowColumnDataSourceMappingsRetriever.retrieve(rule, shadowTables) : result;
     }
 }