You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "clebertsuconic (via GitHub)" <gi...@apache.org> on 2024/03/18 14:33:56 UTC

[PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

clebertsuconic opened a new pull request, #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528729315


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   As the JavaDoc states, "A simple test-case used for documentation purposes." This test is referenced in the Hacking Guide as a guide to help folks get started writing tests. Adding anything superfluous to basic testing is going to diminish the effectiveness of the test as a generic example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528722765


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528725300


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   I don't see any reference from the doc as the javadoc in the test states.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528729315


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   As the JavaDoc states this test is, "A simple test-case used for documentation purposes." This test is referenced in the [Hacking Guide](https://activemq.apache.org/components/artemis/documentation/hacking-guide/#writing-tests) as a guide to help folks get started writing tests. Adding anything superfluous to basic testing is going to diminish the effectiveness of the test as a generic example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528721751


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   This should be in a new test rather than modifying `SimpleTest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528750765


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   Ok.. I had already moved it anyway. thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528723764


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   the test still simple ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ARTEMIS-4691 log.warn on inVM closing [activemq-artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4857:
URL: https://github.com/apache/activemq-artemis/pull/4857#discussion_r1528729315


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/SimpleTest.java:
##########


Review Comment:
   As the JavaDoc states this test is, "A simple test-case used for documentation purposes." This test is referenced in the Hacking Guide as a guide to help folks get started writing tests. Adding anything superfluous to basic testing is going to diminish the effectiveness of the test as a generic example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org