You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/16 03:38:02 UTC

[GitHub] [tinkerpop] xiazcy opened a new pull request, #1757: Gremlin-Go: Update CI to run on Windows

xiazcy opened a new pull request, #1757:
URL: https://github.com/apache/tinkerpop/pull/1757

With these changes, users should be able to run `mvn clean install` in Windows with 3.5-dev successfully.

Main changes are:
1. The removal of the plugin `dockerfile-maven-plugin`, as it is fails on Windows without clear resolution, we are using raw docker build execution in server for image building.
2. The use of `docker-compose` directly instead of the `run.sh` script, as bash script will not work in Windows. The `run.sh` script will remain as an optional tool in gremlin-go for uses to run the tests.

A flag `-DskipImageBuild` is introduced to allow skipping the image building on incompatible platforms. Currently GHA Windows Servers fails when building linux based images (alpine jdk), and so the server image building have been disabled in Spark windows GHA while we investigate alternative resolutions.

For 3.6-dev, running `mvn clean install -pl :gremlin-go` will work in Windows (with a `.glv` file), however, there are errors in other modules which were not encountered in 3.5-dev. These will be investigated and addressed separately.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] kenhuuu commented on pull request #1757: Gremlin-Go: Update CI to run on Windows

Posted by GitBox <gi...@apache.org>.

kenhuuu commented on PR #1757:
URL: https://github.com/apache/tinkerpop/pull/1757#issuecomment-1192812190

   LGTM. This seems helpful for Windows users that want an easy way to build Docker images for the server through Maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] codecov-commenter commented on pull request #1757: Gremlin-Go: Update CI to run on Windows

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #1757:
URL: https://github.com/apache/tinkerpop/pull/1757#issuecomment-1186080816

   # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1757](https://codecov.io/gh/apache/tinkerpop/pull/1757?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fecfb02) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/137cad03e7994b6ba08a15307c2d3d80a9f26f75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (137cad0) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff            @@
   ##           3.5-dev    #1757   +/-   ##
   ========================================
     Coverage    63.58%   63.58%           
   ========================================
     Files           23       23           
     Lines         3636     3636           
   ========================================
     Hits          2312     2312           
     Misses        1145     1145           
     Partials       179      179           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1757?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1757?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [137cad0...fecfb02](https://codecov.io/gh/apache/tinkerpop/pull/1757?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette merged pull request #1757: Gremlin-Go: Update CI to run on Windows

Posted by GitBox <gi...@apache.org>.

spmallette merged PR #1757:
URL: https://github.com/apache/tinkerpop/pull/1757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org