You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by jo...@apache.org on 2015/05/05 06:59:44 UTC
incubator-nifi git commit: NIFI-587 moved checkstyle into profile
with rat plugin. They were too unstable
Repository: incubator-nifi
Updated Branches:
refs/heads/develop 37e5548ac -> 41b21af57
NIFI-587 moved checkstyle into profile with rat plugin. They were too unstable
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/41b21af5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/41b21af5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/41b21af5
Branch: refs/heads/develop
Commit: 41b21af5769211b9a57e5bef47fe40c6d34839b1
Parents: 37e5548
Author: joewitt <jo...@apache.org>
Authored: Tue May 5 00:59:28 2015 -0400
Committer: joewitt <jo...@apache.org>
Committed: Tue May 5 00:59:28 2015 -0400
----------------------------------------------------------------------
nifi-parent/pom.xml | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/41b21af5/nifi-parent/pom.xml
----------------------------------------------------------------------
diff --git a/nifi-parent/pom.xml b/nifi-parent/pom.xml
index 6fcf364..fb2f827 100644
--- a/nifi-parent/pom.xml
+++ b/nifi-parent/pom.xml
@@ -259,14 +259,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>check-style</id>
- <goals>
- <goal>check</goal>
- </goals>
- </execution>
- </executions>
<configuration>
<checkstyleRules>
<module name="Checker">
@@ -377,9 +369,15 @@
</build>
<profiles>
<profile>
- <!-- Automatically check for licenses. Too slow to always run.
- Activate with -P check-licenses -->
- <id>check-licenses</id>
+ <!--
+ Checks style and licensing requirements. This is a good idea to
+ run for contributions and for the release process. While it
+ would be nice to run always these plugins can considerably slow
+ the build and have proven to create unstable builds in our
+ multi-module project and when building using multiple threads.
+ The stability issues seen with Checkstyle in multi-module builds
+ include false-positives and false negatives.-->
+ <id>contrib-check</id>
<build>
<plugins>
<plugin>
@@ -394,6 +392,18 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>check-style</id>
+ <goals>
+ <goal>check</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
</profile>