You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Jungtaek Lim (JIRA)" <ji...@apache.org> on 2018/08/01 04:39:00 UTC

[jira] [Resolved] (SPARK-24311) Refactor HDFSBackedStateStoreProvider to remove duplicated logic between operations on delta file and snapshot file

     [ https://issues.apache.org/jira/browse/SPARK-24311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jungtaek Lim resolved SPARK-24311.
----------------------------------
    Resolution: Won't Fix

As I got feedback on [https://github.com/apache/spark/pull/21357#issuecomment-409427970] the patch is unlikely accepted. Closing this for now.

> Refactor HDFSBackedStateStoreProvider to remove duplicated logic between operations on delta file and snapshot file
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-24311
>                 URL: https://issues.apache.org/jira/browse/SPARK-24311
>             Project: Spark
>          Issue Type: Improvement
>          Components: Structured Streaming
>    Affects Versions: 2.3.0
>            Reporter: Jungtaek Lim
>            Priority: Major
>
> The structure of delta file and snapshot file is same, but the operations are defined as individual methods which incurs duplicated logic between delta file and snapshot file.
> We can refactor to remove duplicated logic to ensure readability, as well as guaranteeing that the structure of delta file and snapshot file keeps same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org