[GitHub] [arrow-rs] alamb commented on a diff in pull request #4148: feat: support `bitwise` shift left/right

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4148:
URL: https://github.com/apache/arrow-rs/pull/4148#discussion_r1180465375


##########
arrow-arith/src/bitwise.rs:
##########
@@ -17,7 +17,9 @@
 
 use crate::arity::{binary, unary};
 use arrow_array::*;
+use arrow_buffer::ArrowNativeType;
 use arrow_schema::ArrowError;
+use num::traits::{WrappingShl, WrappingShr};

Review Comment:
   this is great -- when I looked into doing this in DataFusion I noticed these traits weren't in `std` -- 100% for finding them in `num` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org