You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2018/01/27 00:23:06 UTC

[GitHub] spark pull request #20413: [SC-9624][SS][TESTS] Don't access `lastExecution....

GitHub user zsxwing opened a pull request:

    https://github.com/apache/spark/pull/20413

    [SC-9624][SS][TESTS] Don't access `lastExecution.executedPlan` in StreamTest

    ## What changes were proposed in this pull request?
    
    `lastExecution.executedPlan` is lazy val so accessing it in StreamTest may need to acquire the lock of `lastExecution`. It may be waiting forever when the streaming thread is holding it and running a continuous Spark job.
    
    This PR changes to check if `s.lastExecution` is null to avoid accessing `lastExecution.executedPlan`.
    
    ## How was this patch tested?
    
    Jenkins

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zsxwing/spark SPARK-23245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20413
    
----
commit 3ce18c47fb50f6c1f12db1fb34a6196e5040694d
Author: Jose Torres <jo...@...>
Date:   2018-01-26T22:57:18Z

    better check

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecution.exe...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    **[Test build #4079 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4079/testReport)** for PR 20413 at commit [`3ce18c4`](https://github.com/apache/spark/commit/3ce18c47fb50f6c1f12db1fb34a6196e5040694d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecution.exe...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    Thanks! Merging to master and 2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecution.exe...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    **[Test build #4079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4079/testReport)** for PR 20413 at commit [`3ce18c4`](https://github.com/apache/spark/commit/3ce18c47fb50f6c1f12db1fb34a6196e5040694d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecution.exe...

Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    +1. I originally wrote this line, and I'm reasonably confident that (as indicated by the comment) I didn't intend to check anything other than the nullity of lastExecution. I continue to be confused about why I wrote such a strange null check.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecution.exe...

Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    LGTM.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20413: [SC-9624][SS][TESTS] Don't access `lastExecution.execute...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/20413
  
    cc @jose-torres @tdas 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20413: [SPARK-23245][SS][TESTS] Don't access `lastExecut...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20413


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org