You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/12/11 09:42:11 UTC
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14888
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
IMPALA-9237: Make package binutils building work on aarch64
Set correct environment variables for compiler on aarch64 to make
sure binutils building success on aarch64.
Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
---
M init-compiler.sh
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/88/14888/1
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 16:52:03 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
IMPALA-9237: Make package binutils building work on aarch64
Set correct environment variables for compiler on aarch64 to make
sure binutils building success on aarch64.
Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Reviewed-on: http://gerrit.cloudera.org:8080/14888
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M init-compiler.sh
1 file changed, 13 insertions(+), 4 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Matthew Jacobs, Fredy Wijaya, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14888
to look at the new patch set (#2).
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
IMPALA-9237: Make package binutils building work on aarch64
Set correct environment variables for compiler on aarch64 to make
sure binutils building success on aarch64.
Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
---
M init-compiler.sh
1 file changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/88/14888/2
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 16:52:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh
File init-compiler.sh:
http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh@77
PS1, Line 77: if [[ "$ARCH_NAME" == "aarch64" ]]; then
Can you make this an if/else like the other cases for consistency, e.g.
if [[ "$ARCH_NAME" == "aarch64" ]]; then
CXXFLAGS="$ARCH_FLAGS -fPIC -O3"
else
CXXFLAGS="$ARCH_FLAGS -fPIC -O3 -m64"
fi
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 18:47:36 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-9237: Make package binutils building work on aarch64
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
huangtianhua223@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14888 )
Change subject: IMPALA-9237: Make package binutils building work on aarch64
......................................................................
Patch Set 2:
(1 comment)
Tim Armstrong,
Thanks for reviewing it:)
http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh
File init-compiler.sh:
http://gerrit.cloudera.org:8080/#/c/14888/1/init-compiler.sh@77
PS1, Line 77: CXXFLAGS="$ARCH_FLAGS -fPIC -O3"
> Can you make this an if/else like the other cases for consistency, e.g.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08dbe29357a191b0bfd96a76d1f9d58616880905
Gerrit-Change-Number: 14888
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@apache.org>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 02:11:13 +0000
Gerrit-HasComments: Yes