You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomcat.apache.org by bu...@apache.org on 2002/05/14 00:45:02 UTC

DO NOT REPLY [Bug 9049] New: - org.apache.catalina.core.StandardContext

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9049>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9049

org.apache.catalina.core.StandardContext

           Summary: org.apache.catalina.core.StandardContext
           Product: Tomcat 4
           Version: 4.0.3 Final
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Catalina
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: tvanhusen@libra.de


org.apache.catalina.core.StandardContext

While reading the source code of this class, this looked strange to my eyes
 
    public void addSecurityRole(String role) {
 
        synchronized (securityRoles) {
            String results[] =new String[securityRoles.length + 1];
            for (int i = 0; i < securityRoles.length; i++)
                results[i] = securityRoles[i];
            results[securityRoles.length] = name; // < < - - - - - - - 
            securityRoles = results;
        }
        fireContainerEvent("addSecurityRole", role);
 
    }
 
is "name" correct? It compiles, because name is a field of ContainerBase
(super), but should it not be "role"?

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>