You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Radu Cotescu (Jira)" <ji...@apache.org> on 2022/01/31 16:01:00 UTC

[jira] [Comment Edited] (SLING-9989) Change date formatting to use java.time.format.DateTimeFormatter

    [ https://issues.apache.org/jira/browse/SLING-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484720#comment-17484720 ] 

Radu Cotescu edited comment on SLING-9989 at 1/31/22, 4:00 PM:
---------------------------------------------------------------

[~diru], how does one run the unit tests with Java 11 or above?
{noformat}
[ERROR] Failures:
[ERROR]   FormatFilterExtensionTest.testDateFormatWithEscapedCharacters:109->assertDate:187 expected:<...335; week in year: 4[9]> but was:<...335; week in year: 4[8]>
[INFO]
[ERROR] Tests run: 49, Failures: 1, Errors: 0, Skipped: 0 {noformat}
It seems that although the value for {{java.locale.providers}} is passed to the forked JVM, the test fails.


was (Author: radu.cotescu):
[~diru], how does one run the unit tests with Java 11 or above?
{noformat}
[ERROR] Failures:
[ERROR]   FormatFilterExtensionTest.testDateFormatWithEscapedCharacters:109->assertDate:187 expected:<...335; week in year: 4[9]> but was:<...335; week in year: 4[8]>
[INFO]
[ERROR] Tests run: 49, Failures: 1, Errors: 0, Skipped: 0 {noformat}
It seems that the value for {{java.locale.providers}} is not picked up by surefire.

> Change date formatting to use java.time.format.DateTimeFormatter
> ----------------------------------------------------------------
>
>                 Key: SLING-9989
>                 URL: https://issues.apache.org/jira/browse/SLING-9989
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>            Reporter: Julian Sedding
>            Assignee: Dirk Rudolph
>            Priority: Minor
>             Fix For: Scripting HTL Engine 1.4.12-1.4.0
>
>          Time Spent: 9h
>  Remaining Estimate: 0h
>
> As discussed in SLING-9983, it would be nice to change the implementation from using {{java.text.DateFormat}} to using {{java.time.format.DateTimeFormatter}}.
> cc [~kwin]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)