[GitHub] [maven-compiler-plugin] gnodet commented on a diff in pull request #175: [MCOMPILER-526] Upgrade to parent 39

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #175:
URL: https://github.com/apache/maven-compiler-plugin/pull/175#discussion_r1103867471


##########
src/it/MCOMPILER-474_recompile-dependent-when-package/dependent-module/src/main/java/Main.java:
##########
@@ -16,11 +16,10 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+package foo;

Review Comment:
   We could, but there are tons of files to move manually for no benefit, and those are just tests, so I left it the way it is.  are you fancy doing it ?  I did not found  a trivial way to do that. 
   Fwiw, the java compiler puts the compiled classes in the correct `foo/Main.class` while the groovy compile does not, so I had to move the groovy ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org