You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/20 11:06:50 UTC
[GitHub] [flink] aljoscha commented on a change in pull request #10178:
[FLINK-14433][DataStream] Move generated Jaas conf file from /tmp directory
to Job specific directory
aljoscha commented on a change in pull request #10178: [FLINK-14433][DataStream] Move generated Jaas conf file from /tmp directory to Job specific directory
URL: https://github.com/apache/flink/pull/10178#discussion_r348418240
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/JaasModule.java
##########
@@ -66,19 +71,29 @@
private DynamicConfiguration currentConfig;
+ /**
+ * The working directory that the jaas file will install into.
+ */
+ private final String workingDir;
+
public JaasModule(SecurityConfiguration securityConfig) {
this.securityConfig = checkNotNull(securityConfig);
+ String[] dirs = splitPaths(securityConfig.getFlinkConfig().getString(CoreOptions.TMP_DIRS));
+ // should at least a single directory.
Review comment:
```suggestion
// should be at least one directory.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services