You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/19 07:16:21 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
ericpai opened a new pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#issuecomment-973844982
[](https://coveralls.io/builds/44400943)
Coverage decreased (-0.02%) to 66.92% when pulling **493b85dcb55f6d8305a1b3f7ab24e5d457760290 on ericpai:bugfix/iotdb-2031** into **fc31d50709e6b1f1bae1598232e45c5510b135ae on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#discussion_r753015665
##########
File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java
##########
@@ -231,6 +232,10 @@ protected DescPriorityMergeReader getDescPriorityMergeReader() {
return new DescPriorityMergeReader();
}
+ public static Filter defaultTimeFilter(boolean ascending) {
+ return ascending ? TimeFilter.gtEq(Long.MIN_VALUE) : TimeFilter.ltEq(Long.MAX_VALUE);
+ }
+
Review comment:
Thanks for the comment, it has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#discussion_r753006705
##########
File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java
##########
@@ -231,6 +232,10 @@ protected DescPriorityMergeReader getDescPriorityMergeReader() {
return new DescPriorityMergeReader();
}
+ public static Filter defaultTimeFilter(boolean ascending) {
+ return ascending ? TimeFilter.gtEq(Long.MIN_VALUE) : TimeFilter.ltEq(Long.MAX_VALUE);
+ }
+
Review comment:
You can move the method into `TimeFilter` class and add java doc for this method to indicate that it will return a timefilter thta will always satisfy any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#issuecomment-975339712
@JackieTien97 Hi, are there any other issues to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#issuecomment-973844982
[](https://coveralls.io/builds/44397353)
Coverage increased (+0.007%) to 66.896% when pulling **76870f50ac97b6b03f63db8b008c3a987141e230 on ericpai:bugfix/iotdb-2031** into **d63539b7ec78576b12484a731ac3ff2894f922ed on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Alima777 merged pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster
Posted by GitBox <gi...@apache.org>.
Alima777 merged pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org