You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "joshuayeung (via GitHub)" <gi...@apache.org> on 2023/09/20 14:58:56 UTC

[GitHub] [airflow] joshuayeung opened a new pull request, #34505: Fix multiNamespaceMode not working with executor KubernetesExecutor

joshuayeung opened a new pull request, #34505:
URL: https://github.com/apache/airflow/pull/34505

   Currently, multiNamespaceMode is not working with executor KubernetesExecutor.
   Even though we set the pod override in the executor config, the pod is still generated in the airflow namespace.
   It is suggested to change the order of this pod list to make it work.
   
   See more details:
   https://github.com/apache/airflow/discussions/31990
   
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] joshuayeung commented on pull request #34505: Fix multiNamespaceMode not working with executor KubernetesExecutor

Posted by "joshuayeung (via GitHub)" <gi...@apache.org>.
joshuayeung commented on PR #34505:
URL: https://github.com/apache/airflow/pull/34505#issuecomment-1733495215

   > Could you add a new test which simulates the issue you have with the current implementation? (in [this module](https://github.com/apache/airflow/blob/48930bc0b4c159180cc55c8bd079cdfec9cedb21/tests/providers/cncf/kubernetes/test_pod_generator.py))
   
   Hi @hussein-awala , I have added a test case to test this scenario


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix multiNamespaceMode not working with executor KubernetesExecutor [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34505: Fix multiNamespaceMode not working with executor KubernetesExecutor
URL: https://github.com/apache/airflow/pull/34505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix multiNamespaceMode not working with executor KubernetesExecutor [airflow]

Posted by "andreyolv (via GitHub)" <gi...@apache.org>.
andreyolv commented on PR #34505:
URL: https://github.com/apache/airflow/pull/34505#issuecomment-1743459455

   Thank you very much guys for this fix 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix multiNamespaceMode not working with executor KubernetesExecutor [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #34505:
URL: https://github.com/apache/airflow/pull/34505#issuecomment-1750142999

   helm chart tests are failing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix multiNamespaceMode not working with executor KubernetesExecutor [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34505:
URL: https://github.com/apache/airflow/pull/34505#issuecomment-1820009236

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org