[GitHub] [incubator-superset] bkyryliuk commented on pull request #9667: Fix api limits in react CRUD

[GitBox <gi...@apache.org>]

bkyryliuk commented on pull request #9667:
URL: https://github.com/apache/incubator-superset/pull/9667#issuecomment-620750783


   @dpgaspar I agree that this is imperfect and meant to be only a stop gap solution. Ideally CRUD react needs to know how use pages. This change still allows to specify the page in the url params. Current implementation truncates the results and seems to me as a dangerous behavior as leads to the silent failures that are hard to catch in unit tests & on the dev setup.
   
   > I don't like it, the API should not return all records (except for really exceptional cases) by default.
   > The related endpoint also supports pagination, can you add a bit more context here.
   > 
   > @suddjian maybe you should look at this
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org