[GitHub] QiuMM opened a new pull request #6774: change propertyBase in ServerViewModule

[GitBox <gi...@apache.org>]

QiuMM opened a new pull request #6774: change propertyBase in ServerViewModule
URL: https://github.com/apache/incubator-druid/pull/6774
 
 
   In ServerViewModule:
   ```java
   @Override
     public void configure(Binder binder)
     {
       JsonConfigProvider.bind(binder, "druid.announcer", ServerInventoryViewProvider.class);
       JsonConfigProvider.bind(binder, "druid.announcer", FilteredServerInventoryViewProvider.class);
       JsonConfigProvider.bind(binder, "druid.announcer.http", HttpServerInventoryViewConfig.class);
       binder.bind(InventoryView.class).to(ServerInventoryView.class);
       binder.bind(ServerView.class).to(ServerInventoryView.class);
       binder.bind(ServerInventoryView.class).toProvider(ServerInventoryViewProvider.class).in(ManageLifecycle.class);
       binder.bind(FilteredServerInventoryView.class)
             .toProvider(FilteredServerInventoryViewProvider.class)
             .in(ManageLifecycle.class);
     }
   ```
   In AnnouncerModule:
   ```java
   @Override
     public void configure(Binder binder)
     {
       JsonConfigProvider.bind(binder, "druid.announcer", BatchDataSegmentAnnouncerConfig.class);
       JsonConfigProvider.bind(binder, "druid.announcer", DataSegmentAnnouncerProvider.class);
       binder.bind(DataSegmentAnnouncer.class).toProvider(DataSegmentAnnouncerProvider.class);
       binder.bind(BatchDataSegmentAnnouncer.class).in(LazySingleton.class);
       binder.bind(DataSegmentServerAnnouncer.class).to(CuratorDataSegmentServerAnnouncer.class).in(LazySingleton.class);
     }
   ```
   We can see these two different module use the same `propertyBase` which is weird and may lead to conflicts. This PR using new `propertyBase` to replace the old ones, which might make more sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org