[GitHub] [geode] aditya87 opened pull request #2960: GEODE-5971: Refactor StatusClusterConfigServiceCommand to extend GfshCommand base type

["aditya87 (GitHub)" <gi...@apache.org>]

- Added missing DUnit test for the command.

Signed-off-by: Ken Howe <kh...@pivotal.io>
Signed-off-by: Aditya Anchuri <aa...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2960 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner closed pull request #2960: GEODE-5971: Refactor StatusClusterConfigServiceCommand to extend GfshCommand base type

["pdxrunner (GitHub)" <gi...@apache.org>]

[ pull request closed by pdxrunner ]

[ Full content available at: https://github.com/apache/geode/pull/2960 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on issue #2960: GEODE-5971: Refactor StatusClusterConfigServiceCommand to extend GfshCommand base type

["aditya87 (GitHub)" <gi...@apache.org>]

@jinmeiliao Please take a look and review!

[ Full content available at: https://github.com/apache/geode/pull/2960 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2960: GEODE-5971: Refactor StatusClusterConfigServiceCommand to extend GfshCommand base type

["aditya87 (GitHub)" <gi...@apache.org>]

Cool, will remove.

[ Full content available at: https://github.com/apache/geode/pull/2960 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2960: GEODE-5971: Refactor StatusClusterConfigServiceCommand to extend GfshCommand base type

["jinmeiliao (GitHub)" <gi...@apache.org>]

no need to do this. all  locators/servers started by the rule will be shut down by the rule.

[ Full content available at: https://github.com/apache/geode/pull/2960 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org