You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/15 23:09:20 UTC

[jira] [Commented] (NIFI-2902) S3 Processor Signer Override for v4 Throws Exception

    [ https://issues.apache.org/jira/browse/NIFI-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578897#comment-15578897 ] 

ASF GitHub Bot commented on NIFI-2902:
--------------------------------------

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1140

    NIFI-2902 Fix for S3 Signer v4 Override

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-2902-s3-signer-v4-fix-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1140
    
----
commit cbe9595be44be6613142fba0242184536c7795ac
Author: James Wing <jv...@gmail.com>
Date:   2016-10-15T19:49:15Z

    NIFI-2902 Fix for S3 Signer v4 Override

----


> S3 Processor Signer Override for v4 Throws Exception
> ----------------------------------------------------
>
>                 Key: NIFI-2902
>                 URL: https://issues.apache.org/jira/browse/NIFI-2902
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: James Wing
>            Assignee: James Wing
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> NIFI-2763 introduced optional signer overrides for S3 processors - default, v2, and v4.  The signer type for the "Signature v4" is wrong, and throws an IllegalArgumentException when the processor attempts to start.  The failing type is {{AWSS3V4Signer}}.  The correct type is {{AWSS3V4SignerType}}.
> The impact is low for now - the feature has not been released, and the unconfigured default is v4 in the AWS SDK included with NiFi.  The "Signature v2" value works OK.  But the option does not work as advertised, and should be fixed before release.
> {code}
> 2016-10-14 17:46:28,685 ERROR [StandardProcessScheduler Thread-3] org.apache.nifi.engine.FlowEngine A flow controller task execution stopped abnormally
> java.util.concurrent.ExecutionException: java.lang.reflect.InvocationTargetException
> 	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[na:1.8.0_66]
> 	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[na:1.8.0_66]
> 	at org.apache.nifi.engine.FlowEngine.afterExecute(FlowEngine.java:100) ~[na:na]
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1150) [na:1.8.0_66]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_66]
> 	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]
> Caused by: java.lang.reflect.InvocationTargetException: null
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_66]
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_66]
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_66]
> 	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_66]
> 	at org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:137) ~[na:na]
> 	at org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:125) ~[na:na]
> 	at org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:70) ~[na:na]
> 	at org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:47) ~[na:na]
> 	at org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1244) ~[na:na]
> 	at org.apache.nifi.controller.StandardProcessorNode$1$1.call(StandardProcessorNode.java:1240) ~[na:na]
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_66]
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) ~[na:1.8.0_66]
> 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) ~[na:1.8.0_66]
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_66]
> 	... 2 common frames omitted
> Caused by: java.lang.IllegalArgumentException: unknown signer type: AWSS3V4Signer
> 	at com.amazonaws.auth.SignerFactory.createSigner(SignerFactory.java:118) ~[na:na]
> 	at com.amazonaws.auth.SignerFactory.getSignerByTypeAndService(SignerFactory.java:95) ~[na:na]
> 	at com.amazonaws.AmazonWebServiceClient.computeSignerByServiceRegion(AmazonWebServiceClient.java:262) ~[na:na]
> 	at com.amazonaws.AmazonWebServiceClient.computeSignerByURI(AmazonWebServiceClient.java:235) ~[na:na]
> 	at com.amazonaws.AmazonWebServiceClient.setEndpoint(AmazonWebServiceClient.java:186) ~[na:na]
> 	at com.amazonaws.services.s3.AmazonS3Client.setEndpoint(AmazonS3Client.java:463) ~[na:na]
> 	at com.amazonaws.services.s3.AmazonS3Client.init(AmazonS3Client.java:449) ~[na:na]
> 	at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:396) ~[na:na]
> 	at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:373) ~[na:na]
> 	at com.amazonaws.services.s3.AmazonS3Client.<init>(AmazonS3Client.java:355) ~[na:na]
> 	at org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:137) ~[na:na]
> 	at org.apache.nifi.processors.aws.s3.AbstractS3Processor.createClient(AbstractS3Processor.java:45) ~[na:na]
> 	at org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor.onScheduledUsingControllerService(AbstractAWSCredentialsProviderProcessor.java:73) ~[na:na]
> 	at org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor.onScheduled(AbstractAWSCredentialsProviderProcessor.java:61) ~[na:na]
> 	... 16 common frames omitted
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)