[commons-dbcp] branch master updated: Add SpotBugs check to default Maven goal

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b65b80c Add SpotBugs check to default Maven goal
6b65b80c is described below

commit 6b65b80c6c33b7df4363b1133df7e1cbeb45ace5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jul 4 10:05:30 2022 -0400

    Add SpotBugs check to default Maven goal
---
 pom.xml                              | 2 +-
 src/conf/findbugs-exclude-filter.xml | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c4c233c3..36381c73 100644
--- a/pom.xml
+++ b/pom.xml
@@ -351,7 +351,7 @@
   </properties>
 
   <build>
-    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check pmd:check javadoc:javadoc</defaultGoal>
+    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check spotbugs:check pmd:check javadoc:javadoc</defaultGoal>
     <pluginManagement>
       <plugins>
         <plugin>
diff --git a/src/conf/findbugs-exclude-filter.xml b/src/conf/findbugs-exclude-filter.xml
index 1d06564d..29ab31aa 100644
--- a/src/conf/findbugs-exclude-filter.xml
+++ b/src/conf/findbugs-exclude-filter.xml
@@ -76,4 +76,12 @@
     <Field name="DISCONNECTION_SQL_CODES" />
     <Bug pattern="MS_MUTABLE_COLLECTION_PKGPROTECT" />
   </Match>
+  <Match>
+    <!-- SpotBugs 4.7.0: These seem pointless unless all classes are specified to be immutable -->
+    <Bug pattern="EI_EXPOSE_REP" />
+  </Match>
+  <Match>
+    <!-- SpotBugs 4.7.0: These seem pointless unless all classes are specified to be immutable -->
+    <Bug pattern="EI_EXPOSE_REP2" />
+  </Match>
 </FindBugsFilter>