[GitHub] [royale-asjs] greg-dove commented on issue #641: Fix PAYG violations and code debt

[GitBox <gi...@apache.org>]

greg-dove commented on issue #641: Fix PAYG violations and code debt
URL: https://github.com/apache/royale-asjs/issues/641#issuecomment-569524884
 
 
   Hi Harbs,
   
   A couple of quick comments:
   
   
   Reflection data is included in debug build as it should be, but last time I
   checked I think it was completely omitted in HelloWorld release build.
   Please let me know if that is not the case.
   
   
   If you have a static utils class, you can eliminate reflection and export
   selectively on that class by annotating the class itself with
   @royalesuppressexport. I did this already with js Language, for example.
   This approach should not be used without consideration about how it limits
   use of the class. But I think it would probably be low risk for sets of
   utility functions. It would not be advisable for the general case with a
   class that has public static costs for example... they may need to be
   accessed with string keys in release build (if used in mxml bindings for
   example) and therefore continue to need 'export'
   
   
   
   
   
   On Mon, 30 Dec 2019, 01:08 Harbs, <no...@github.com> wrote:
   
   > I don't remember why public functions are exported. getters need to be
   > exported for MXML support, but I'm not sure why that would apply to
   > functions.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/royale-asjs/issues/641?email_source=notifications&email_token=ABC3PVQO5AEM6IZ4UFFAAZTQ3CHLHA5CNFSM4KA3KYFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHY56GQ#issuecomment-569499418>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABC3PVRBMV2QK454VMXPAEDQ3CHLHANCNFSM4KA3KYFA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services