You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/05/06 00:35:04 UTC
[jira] [Created] (HDFS-1896) Additional QA tasks for Edit Log
branch
Additional QA tasks for Edit Log branch
---------------------------------------
Key: HDFS-1896
URL: https://issues.apache.org/jira/browse/HDFS-1896
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Todd Lipcon
Assignee: Todd Lipcon
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061014#comment-13061014 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
I just manually tested HDFS-1969's new functionality and it seems to be working:
- formatted NN using 0.20
- ran NN from 1073 branch - it complained about wrong layout
- ran 1073 NN with -upgrade flag, it started with upgrade
- ran 1073 NN with -rollback flag, it correctly complained
- ran 0.20 NN with -rollback flag, it rolled back to old namespace
Once all of the currently outstanding patches are applied, the upgrade tests also seem to be passing, so I think we're OK on that one.
I agree there are lots of unused imports. I'll do a pass to clean them up right before we merge.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060981#comment-13060981 ]
Aaron T. Myers commented on HDFS-1896:
--------------------------------------
I've gone through the list. Most things appear to be fine. The only issues I found were the following:
# HDFS-1955 - This appears to have entirely regressed in 1073.
# HDFS-1149 - I bet the change to {{NNStorage.setFields(...)}} will cause the upgrade tests to break. At the very least, there are now some unused imports in {{NNStorage}} on the 1073 branch.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029626#comment-13029626 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
Some things around failure handling:
- make sure we can still disable the "automatic storage restore" feature, if necessary?
- make sure the NN still shuts itself down if all edits directories become inaccessible
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-1896:
------------------------------
Affects Version/s: Edit log branch (HDFS-1073)
Fix Version/s: Edit log branch (HDFS-1073)
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035976#comment-13035976 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
Another test scenario:
- NN starts up, writes some edits, crashes
- NN starts up again, writes some more edits
- Checkpoint occurs
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030034#comment-13030034 ]
Konstantin Boudnik commented on HDFS-1896:
------------------------------------------
Can I say 'testplan'? With HDFS-265 comes to mind.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030043#comment-13030043 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
Cos: there's a small test plan attached to the design doc over at HDFS-1073. I just wanted to have a convenient place to jot down additional tasks as we go along.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061008#comment-13061008 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
bq. I bet the change to NNStorage.setFields(...) will cause the upgrade tests to break.
hmm, you sure you mean 1149 (the lease reassignment fix?) I'm not sure I see how that relates to NNStorage.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-1896:
------------------------------
Description: As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061011#comment-13061011 ]
Aaron T. Myers commented on HDFS-1896:
--------------------------------------
Sorry, I meant HDFS-1969 not HDFS-1149.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061009#comment-13061009 ]
Todd Lipcon commented on HDFS-1896:
-----------------------------------
btw, thanks for looking into these details. I'll file a JIRA about fixing 1955.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060949#comment-13060949 ]
Aaron T. Myers commented on HDFS-1896:
--------------------------------------
I just took a manual pass through the commits to trunk which have occurred since the branch was created for HDFS-1073. Here's the list of JIRAs which I think may be relevant:
* HDFS-2011
* HDFS-1955
* HDFS-988
* HDFS-2041
* HDFS-2030
* HDFS-2003
* HDFS-1948
* HDFS-1149
* HDFS-1969
* HDFS-1636
* HDFS-1936
I'm going to try to manually verify that these fixes did not regress in the HDFS-1073 branch.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060964#comment-13060964 ]
Aaron T. Myers commented on HDFS-1896:
--------------------------------------
Oh, also, though it's not committed yet, HDFS-2132 likely will be soon. This will also need to be ported to the HDFS-1073 branch.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-1896) Additional QA tasks for Edit Log
branch
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HDFS-1896.
-------------------------------
Resolution: Not A Problem
The items needing manual testing have been tested, and the branch is long since merged. Marking resolved.
> Additional QA tasks for Edit Log branch
> ---------------------------------------
>
> Key: HDFS-1896
> URL: https://issues.apache.org/jira/browse/HDFS-1896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> As we close out tasks in the HDFS-1073 branch, there are a few places where I've noticed that we lack some test coverage. Creating this ticket just as a place to jot down some notes on things that we ought to make sure are tested, preferably by automated (unit) tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira