[GitHub] bowenli86 commented on a change in pull request #7409: [FLINK-11064] [table] Setup a new flink-table module structure

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #7409: [FLINK-11064] [table] Setup a new flink-table module structure
URL: https://github.com/apache/flink/pull/7409#discussion_r246173465
 
 

 ##########
 File path: flink-table/flink-table-api-java/pom.xml
 ##########
 @@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+	<modelVersion>4.0.0</modelVersion>
+
+	<parent>
+		<groupId>org.apache.flink</groupId>
+		<artifactId>flink-table</artifactId>
+		<version>1.8-SNAPSHOT</version>
+		<relativePath>..</relativePath>
+	</parent>
+
+	<artifactId>flink-table-api-java_${scala.binary.version}</artifactId>
+	<name>flink-table-api-java</name>
+
+	<packaging>jar</packaging>
+
+	<dependencies>
+		<!-- Base Table API classes. -->
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-table-api-base</artifactId>
+			<version>${project.version}</version>
+		</dependency>
+		<!-- Integration with Java DataSet/DataStream API. -->
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
+			<version>${project.version}</version>
+			<scope>provided</scope>
+		</dependency>
+	</dependencies>
+
+	<build>
+		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
 
 Review comment:
   To avoid confusions like Aljoscha raised, does `maven-assembly-plugin` fit better here?  `maven-assembly-plugin` may already meet our needs.
   
   Using maven-shade-plugin to build a fat jar is fine for me too. Either way, it would be great to add the discussion result as an explanation here, and it can be addressed in a later PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services