You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Christian Schulte <cs...@schulte.it> on 2016/12/11 22:41:55 UTC
extensions.xml (Re: [4/7] maven git commit: [MNG-6110] Upgrade Aether
to Maven Resolver 1.2)
Can someone please take a look at this and verify the changes are
correct? I am not sure the former artifacts also need to be exported.
For the sonatype ones the package names are different. For the eclipse
ones the package names are identical. Not sure, though.
<exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
<exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
<exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
Am 12/11/16 um 23:37 schrieb schulte@apache.org:
> http://git-wip-us.apache.org/repos/asf/maven/blob/58554032/maven-core/src/main/resources/META-INF/maven/extension.xml
> ----------------------------------------------------------------------
> diff --git a/maven-core/src/main/resources/META-INF/maven/extension.xml b/maven-core/src/main/resources/META-INF/maven/extension.xml
> index eaa807b..55e0096 100644
> --- a/maven-core/src/main/resources/META-INF/maven/extension.xml
> +++ b/maven-core/src/main/resources/META-INF/maven/extension.xml
> @@ -54,7 +54,7 @@ under the License.
> <exportedPackage>org.apache.maven.wagon.repository</exportedPackage>
> <exportedPackage>org.apache.maven.wagon.resource</exportedPackage>
>
> - <!-- aether-api, aether-spi, aether-impl -->
> + <!-- maven-resolver-api, maven-resolver-spi, maven-resolver-impl -->
> <exportedPackage>org.eclipse.aether.*</exportedPackage>
> <exportedPackage>org.eclipse.aether.artifact</exportedPackage>
> <exportedPackage>org.eclipse.aether.collection</exportedPackage>
> @@ -134,7 +134,7 @@ under the License.
> <exportedArtifact>org.sonatype.sisu:sisu-inject-plexus</exportedArtifact>
> <exportedArtifact>org.eclipse.sisu:org.eclipse.sisu.plexus</exportedArtifact>
> <exportedArtifact>org.apache.maven:maven-artifact</exportedArtifact>
> - <exportedArtifact>org.apache.maven:maven-aether-provider</exportedArtifact>
> + <exportedArtifact>org.apache.maven:maven-resolver-provider</exportedArtifact>
> <exportedArtifact>org.apache.maven:maven-artifact-manager</exportedArtifact>
> <exportedArtifact>org.apache.maven:maven-compat</exportedArtifact>
> <exportedArtifact>org.apache.maven:maven-core</exportedArtifact>
> @@ -154,9 +154,9 @@ under the License.
> <exportedArtifact>org.apache.maven:maven-settings-builder</exportedArtifact>
> <exportedArtifact>org.apache.maven:maven-toolchain</exportedArtifact>
> <exportedArtifact>org.apache.maven.wagon:wagon-provider-api</exportedArtifact>
> - <exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
> - <exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
> - <exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
> + <exportedArtifact>org.apache.maven.resolver:maven-resolver-api</exportedArtifact>
> + <exportedArtifact>org.apache.maven.resolver:maven-resolver-spi</exportedArtifact>
> + <exportedArtifact>org.apache.maven.resolver:maven-resolver-impl</exportedArtifact>
>
> <exportedArtifact>javax.inject:javax.inject</exportedArtifact>
> <exportedArtifact>javax.annotation:jsr250-api</exportedArtifact>
> @@ -169,6 +169,9 @@ under the License.
> <exportedArtifact>org.sonatype.aether:aether-api</exportedArtifact>
> <exportedArtifact>org.sonatype.aether:aether-spi</exportedArtifact>
> <exportedArtifact>org.sonatype.aether:aether-impl</exportedArtifact>
> + <exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
> + <exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
> + <exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
>
> <!--
> | NOTE: Don't exclude the wagons or any of their dependencies (apart from the wagon API). This would otherwise
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: extensions.xml (Re: [4/7] maven git commit: [MNG-6110] Upgrade
Aether to Maven Resolver 1.2)
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
The list of exported artifacts appears to be correct. It effectively
removes listed artifacts from plugin realms and forces plugins to use
classes exported from core realm.
We obviously need to do this org.eclipse.aether artifacts to avoid
multiple versions of the same classes present both in maven core and in
plugin realm.
I don't remember why we need to filter org.sonatype.aether, but that
aether version cannot be used with maven core, so at very least the
filter will force earlier ClassNotFoundError, which I believe is
useful.
[1] http://takari.io/book/91-maven-classloading.html
--
Regards,
Igor
On Sun, Dec 11, 2016, at 05:41 PM, Christian Schulte wrote:
> Can someone please take a look at this and verify the changes are
> correct? I am not sure the former artifacts also need to be exported.
> For the sonatype ones the package names are different. For the eclipse
> ones the package names are identical. Not sure, though.
>
> <exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
> <exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
> <exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
>
>
> Am 12/11/16 um 23:37 schrieb schulte@apache.org:
> > http://git-wip-us.apache.org/repos/asf/maven/blob/58554032/maven-core/src/main/resources/META-INF/maven/extension.xml
> > ----------------------------------------------------------------------
> > diff --git a/maven-core/src/main/resources/META-INF/maven/extension.xml b/maven-core/src/main/resources/META-INF/maven/extension.xml
> > index eaa807b..55e0096 100644
> > --- a/maven-core/src/main/resources/META-INF/maven/extension.xml
> > +++ b/maven-core/src/main/resources/META-INF/maven/extension.xml
> > @@ -54,7 +54,7 @@ under the License.
> > <exportedPackage>org.apache.maven.wagon.repository</exportedPackage>
> > <exportedPackage>org.apache.maven.wagon.resource</exportedPackage>
> >
> > - <!-- aether-api, aether-spi, aether-impl -->
> > + <!-- maven-resolver-api, maven-resolver-spi, maven-resolver-impl -->
> > <exportedPackage>org.eclipse.aether.*</exportedPackage>
> > <exportedPackage>org.eclipse.aether.artifact</exportedPackage>
> > <exportedPackage>org.eclipse.aether.collection</exportedPackage>
> > @@ -134,7 +134,7 @@ under the License.
> > <exportedArtifact>org.sonatype.sisu:sisu-inject-plexus</exportedArtifact>
> > <exportedArtifact>org.eclipse.sisu:org.eclipse.sisu.plexus</exportedArtifact>
> > <exportedArtifact>org.apache.maven:maven-artifact</exportedArtifact>
> > - <exportedArtifact>org.apache.maven:maven-aether-provider</exportedArtifact>
> > + <exportedArtifact>org.apache.maven:maven-resolver-provider</exportedArtifact>
> > <exportedArtifact>org.apache.maven:maven-artifact-manager</exportedArtifact>
> > <exportedArtifact>org.apache.maven:maven-compat</exportedArtifact>
> > <exportedArtifact>org.apache.maven:maven-core</exportedArtifact>
> > @@ -154,9 +154,9 @@ under the License.
> > <exportedArtifact>org.apache.maven:maven-settings-builder</exportedArtifact>
> > <exportedArtifact>org.apache.maven:maven-toolchain</exportedArtifact>
> > <exportedArtifact>org.apache.maven.wagon:wagon-provider-api</exportedArtifact>
> > - <exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
> > - <exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
> > - <exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
> > + <exportedArtifact>org.apache.maven.resolver:maven-resolver-api</exportedArtifact>
> > + <exportedArtifact>org.apache.maven.resolver:maven-resolver-spi</exportedArtifact>
> > + <exportedArtifact>org.apache.maven.resolver:maven-resolver-impl</exportedArtifact>
> >
> > <exportedArtifact>javax.inject:javax.inject</exportedArtifact>
> > <exportedArtifact>javax.annotation:jsr250-api</exportedArtifact>
> > @@ -169,6 +169,9 @@ under the License.
> > <exportedArtifact>org.sonatype.aether:aether-api</exportedArtifact>
> > <exportedArtifact>org.sonatype.aether:aether-spi</exportedArtifact>
> > <exportedArtifact>org.sonatype.aether:aether-impl</exportedArtifact>
> > + <exportedArtifact>org.eclipse.aether:aether-api</exportedArtifact>
> > + <exportedArtifact>org.eclipse.aether:aether-spi</exportedArtifact>
> > + <exportedArtifact>org.eclipse.aether:aether-impl</exportedArtifact>
> >
> > <!--
> > | NOTE: Don't exclude the wagons or any of their dependencies (apart from the wagon API). This would otherwise
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org