You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/11 02:05:14 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4422: In ClusterChangeMediator,
stop enqueue/process changes if already stopped
Jackie-Jiang commented on a change in pull request #4422: In ClusterChangeMediator, stop enqueue/process changes if already stopped
URL: https://github.com/apache/incubator-pinot/pull/4422#discussion_r302338332
##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/ClusterChangeMediator.java
##########
@@ -145,15 +145,15 @@ private void processClusterChange(ChangeType changeType, List<ClusterChangeHandl
/**
* Starts the cluster change mediator.
*/
- public void start() {
+ public synchronized void start() {
Review comment:
Just for safety. This method will be called only once, so no performance impact
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org