You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Efrat19 (via GitHub)" <gi...@apache.org> on 2026/01/29 12:14:37 UTC
[PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Efrat19 opened a new pull request, #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise merged PR #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217#issuecomment-3891128778
> @Efrat19 thank you for fixing this. I am wondering why the check licensing stage in the CI did not catch this when the files were added originally; I suspect the check licensing my need to be more robust if it missed this.
Yep we should definitely look into this. Created https://issues.apache.org/jira/browse/FLINK-39080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217#issuecomment-3822760492
@Efrat19 thank you for fixing this. I am wondering why the check licensing stage in the CI did not catch this when the files were added originally; I suspect the check licensing my need to be more robust if it missed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217#issuecomment-3999963649
> > I think the [license check](https://github.com/apache/flink-connector-shared-utils/blame/ci_utils/.github/workflows/ci.yml#L182-L187) is just missing rat, and working to add it
>
> Good idea, just do it!
@loserwang1024 https://github.com/apache/flink-connector-kafka/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38999][lineage] License lineage files [flink-connector-kafka]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 commented on PR #217:
URL: https://github.com/apache/flink-connector-kafka/pull/217#issuecomment-3956641611
I wonder why compile successfully before? Maybe we also need to add a force check( see what flink repo does https://github.com/apache/flink/blob/5440238393dfeb7d7a7c3463359f61446655ea0d/pom.xml#L1609)
@Efrat19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org