You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ps...@apache.org on 2005/09/11 06:47:19 UTC
svn commit: r280074 - in /jakarta/commons/proper/math/branches/MATH_1_1:
src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java
xdocs/changes.xml
Author: psteitz
Date: Sat Sep 10 21:47:16 2005
New Revision: 280074
URL: http://svn.apache.org/viewcvs?rev=280074&view=rev
Log:
Eliminated floating point equals comparison in Percentile.evaluate.
PR# 36491 (findbugs)
Modified:
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java
jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml
Modified: jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java?rev=280074&r1=280073&r2=280074&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java (original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/rank/Percentile.java Sat Sep 10 21:47:16 2005
@@ -186,13 +186,13 @@
if ((p > 100) || (p <= 0)) {
throw new IllegalArgumentException("invalid quantile value: " + p);
}
- double n = (double) length;
- if (n == 0) {
+ if (length == 0) {
return Double.NaN;
}
- if (n == 1) {
+ if (length == 1) {
return values[begin]; // always return single value for n = 1
}
+ double n = (double) length;
double pos = p * (n + 1) / 100;
double fpos = Math.floor(pos);
int intPos = (int) fpos;
Modified: jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml?rev=280074&r1=280073&r2=280074&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml (original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml Sat Sep 10 21:47:16 2005
@@ -46,6 +46,9 @@
possible to replace the JDK-supplied random number generator in
commons-math (and elsewhere) with alternative PRNG implementations.">
<action dev="psteitz" type="fix" issue="36491">
+ Eliminated floating point equals comparison in Percentile.evaluate.
+ </action>
+ <action dev="psteitz" type="fix" issue="36491">
Eliminated unnecessary assignment statements in Skewness.getResult
method.
</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org