[GitHub] [doris] yiguolei commented on a diff in pull request #17146: [fix](delete) fix delete from bug which can get wrong result

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #17146:
URL: https://github.com/apache/doris/pull/17146#discussion_r1118190483


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -379,7 +379,9 @@ Status SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row
         DCHECK(_opts.col_id_to_predicates.count(cid) > 0);
         RETURN_IF_ERROR(_column_iterators[_schema.unique_id(cid)]->get_row_ranges_by_zone_map(
                 _opts.col_id_to_predicates[cid].get(),
-                _opts.col_id_to_del_predicates.count(cid) > 0
+                _opts.col_id_to_del_predicates.size() == 1 &&

Review Comment:
   If user send to delete predicates:
   1. delete where a = 1
   2. delete where a = 2
   
   In this pr, the delete predicate will take no effect?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org