You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/01/16 08:01:24 UTC

[Impala-ASF-CR] IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12217 )

Change subject: IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW
......................................................................

IMPALA-7679: Improve error message when adding NULL column in CTAS, CREATE VIEW and ALTER VIEW

This patch improves the error message to be more helpful when inserting
a NULL column in CTAS, CREATE VIEW, and ALTER VIEW  without an explicit
cast due to the inability to infer the column type.

Testing:
- Added new FE tests
- Ran all FE tests

Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82
---
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
3 files changed, 38 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/12217/6
-- 
To view, visit http://gerrit.cloudera.org:8080/12217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia2fe1fc96f0650477c0e897c010be3fadabfaf82
Gerrit-Change-Number: 12217
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>