You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/05 05:42:47 UTC
[GitHub] [apisix] oil-oil opened a new pull request, #7385: docs: fix command format
oil-oil opened a new pull request, #7385:
URL: https://github.com/apache/apisix/pull/7385
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a diff in pull request #7385: docs: fix command format
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #7385:
URL: https://github.com/apache/apisix/pull/7385#discussion_r914672893
##########
docs/en/latest/plugins/basic-auth.md:
##########
@@ -97,7 +97,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
After you have configured the Plugin as mentioned above, you can make a request to the Route as shown below:
```shell
-curl -i -ufoo:bar http://127.0.0.1:9080/hello
+curl -i -u foo:bar http://127.0.0.1:9080/hello
Review Comment:
I think it's equal but `-u foo:bar` will be clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7385: docs: fix command format
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7385:
URL: https://github.com/apache/apisix/pull/7385#discussion_r914364978
##########
docs/en/latest/plugins/basic-auth.md:
##########
@@ -97,7 +97,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
After you have configured the Plugin as mentioned above, you can make a request to the Route as shown below:
```shell
-curl -i -ufoo:bar http://127.0.0.1:9080/hello
+curl -i -u foo:bar http://127.0.0.1:9080/hello
Review Comment:
`-u foo:bar` means means `foo:bar` is `<user:password>`, and here `-u` equal `--user`? see: https://curl.se/docs/manpage.html and search `-u, --user <user:password>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7385: docs: fix command format
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7385:
URL: https://github.com/apache/apisix/pull/7385#discussion_r913406733
##########
docs/en/latest/plugins/basic-auth.md:
##########
@@ -97,7 +97,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
After you have configured the Plugin as mentioned above, you can make a request to the Route as shown below:
```shell
-curl -i -ufoo:bar http://127.0.0.1:9080/hello
+curl -i -u foo:bar http://127.0.0.1:9080/hello
Review Comment:
Both `-ufoo:bar` and `-u foo:bar` are equal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] oil-oil closed pull request #7385: docs: fix command format
Posted by GitBox <gi...@apache.org>.
oil-oil closed pull request #7385: docs: fix command format
URL: https://github.com/apache/apisix/pull/7385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] oil-oil commented on a diff in pull request #7385: docs: fix command format
Posted by GitBox <gi...@apache.org>.
oil-oil commented on code in PR #7385:
URL: https://github.com/apache/apisix/pull/7385#discussion_r913463414
##########
docs/en/latest/plugins/basic-auth.md:
##########
@@ -97,7 +97,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
After you have configured the Plugin as mentioned above, you can make a request to the Route as shown below:
```shell
-curl -i -ufoo:bar http://127.0.0.1:9080/hello
+curl -i -u foo:bar http://127.0.0.1:9080/hello
Review Comment:
> Both `-ufoo:bar` and `-u foo:bar` are equal?
I'm not sure if it's equal, but I think adding a space would make it clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org