You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/03 11:21:34 UTC
[GitHub] [doris] starocean999 opened a new pull request, #13953: [fix](repeat)remove unmaterialized expr from repeat node
starocean999 opened a new pull request, #13953:
URL: https://github.com/apache/doris/pull/13953
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13953:
URL: https://github.com/apache/doris/pull/13953#issuecomment-1304505814
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13953:
URL: https://github.com/apache/doris/pull/13953#issuecomment-1304505811
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #13953:
URL: https://github.com/apache/doris/pull/13953#discussion_r1014625563
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/GroupingInfo.java:
##########
@@ -89,7 +89,30 @@ public List<Expr> getPreRepeatExprs() {
}
public void substitutePreRepeatExprs(ExprSubstitutionMap smap, Analyzer analyzer) {
+ ArrayList<Expr> originalPreRepeatExprs = new ArrayList<>(preRepeatExprs);
preRepeatExprs = Expr.substituteList(preRepeatExprs, smap, analyzer, true);
+
+ // remove unmaterialized slotRef from preRepeatExprs
+ ArrayList<Expr> materializedPreRepeatExprs = new ArrayList<>();
+ ArrayList<Expr> unMaterializedSlotRefs = new ArrayList<>();
+ for (int i = 0; i < preRepeatExprs.size(); ++i) {
+ Expr expr = preRepeatExprs.get(i);
+ if (expr instanceof SlotRef && !((SlotRef) expr).getDesc().isMaterialized()) {
+ unMaterializedSlotRefs.add(originalPreRepeatExprs.get(i));
+ } else {
+ materializedPreRepeatExprs.add(expr);
+ }
+ }
+ preRepeatExprs = materializedPreRepeatExprs;
+
+ // remove unmaterialized slotRef from outputTupleSmap and outputTupleDesc if there is any
+ for (Expr expr : unMaterializedSlotRefs) {
+ Expr rExpr = outputTupleSmap.get(expr);
+ outputTupleSmap.removeByRhsExpr(rExpr);
+ if (rExpr instanceof SlotRef) {
+ outputTupleDesc.getSlots().remove(((SlotRef) rExpr).getDesc());
Review Comment:
is it better to set it as not materialized instead of remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13953:
URL: https://github.com/apache/doris/pull/13953#issuecomment-1302319251
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.82 seconds
load time: 613 seconds
storage size: 17184113351 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221103155340_clickbench_pr_39510.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] starocean999 commented on a diff in pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
starocean999 commented on code in PR #13953:
URL: https://github.com/apache/doris/pull/13953#discussion_r1014957872
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/GroupingInfo.java:
##########
@@ -89,7 +89,30 @@ public List<Expr> getPreRepeatExprs() {
}
public void substitutePreRepeatExprs(ExprSubstitutionMap smap, Analyzer analyzer) {
+ ArrayList<Expr> originalPreRepeatExprs = new ArrayList<>(preRepeatExprs);
preRepeatExprs = Expr.substituteList(preRepeatExprs, smap, analyzer, true);
+
+ // remove unmaterialized slotRef from preRepeatExprs
+ ArrayList<Expr> materializedPreRepeatExprs = new ArrayList<>();
+ ArrayList<Expr> unMaterializedSlotRefs = new ArrayList<>();
+ for (int i = 0; i < preRepeatExprs.size(); ++i) {
+ Expr expr = preRepeatExprs.get(i);
+ if (expr instanceof SlotRef && !((SlotRef) expr).getDesc().isMaterialized()) {
+ unMaterializedSlotRefs.add(originalPreRepeatExprs.get(i));
+ } else {
+ materializedPreRepeatExprs.add(expr);
+ }
+ }
+ preRepeatExprs = materializedPreRepeatExprs;
+
+ // remove unmaterialized slotRef from outputTupleSmap and outputTupleDesc if there is any
+ for (Expr expr : unMaterializedSlotRefs) {
+ Expr rExpr = outputTupleSmap.get(expr);
+ outputTupleSmap.removeByRhsExpr(rExpr);
+ if (rExpr instanceof SlotRef) {
+ outputTupleDesc.getSlots().remove(((SlotRef) rExpr).getDesc());
Review Comment:
set unmaterialized is better, code is updated, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13953: [fix](repeat)remove unmaterialized expr from repeat node
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13953:
URL: https://github.com/apache/doris/pull/13953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org