[jira] [Commented] (AMBARI-11659) Blueprint processor filters should have better error handling for invalid configuration types

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-11659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571758#comment-14571758 ] 

Hadoop QA commented on AMBARI-11659:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12737306/AMBARI-11659.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.controller.metrics.timeline.AMSPropertyProviderTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/3013//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/3013//console

This message is automatically generated.

> Blueprint processor filters should have better error handling for invalid configuration types
> ---------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-11659
>                 URL: https://issues.apache.org/jira/browse/AMBARI-11659
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Robert Nettleton
>            Assignee: Robert Nettleton
>            Priority: Critical
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-11659.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The new Blueprint's filtering mechanism in the BlueprintConfigProcessor needs to handle exceptions/errors in a more graceful way.
> Currently, if a Blueprint contains an invalid configuration type, this will cause the underlying Stack code to throw a RuntimeException. This in turn causes config processing to fail, and never reach the topology resolution stage.  A cluster in this state will likely fail, since it's configuration items never move beyond the "INITIAL" state, and don't have the correct topology updates in order for services to locate each other.  
> The Blueprint internal filters should catch any RuntimeExceptions thrown by the Stack processing code, but should only log these exceptions.  Since Blueprints uses an asynchronous model now for config processing, these types of errors can only be logged, they cannot stop the overall process of a cluster deployment.  This should allow the cluster to at least startup properly, as long as the rest of the configuration is valid.
> I'm working on a fix for this, and will submit a patch shortly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)