[GitHub] [geode] mivanac commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

[GitBox <gi...@apache.org>]

mivanac commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r421245781



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -692,6 +704,17 @@ public int getDSFID() {
   @Override
   public void toData(DataOutput out,
       SerializationContext context) throws IOException {
+    toDataPre_GEODE_1_13_0_0(out, context);
+    boolean hasTransaction = this.transactionId != null;
+    DataSerializer.writeBoolean(hasTransaction, out);
+    if (hasTransaction) {
+      DataSerializer.writeBoolean(this.isLastEventInTransaction, out);
+      context.getSerializer().writeObject(this.transactionId, out);
+    }
+  }
+
+  public void toDataPre_GEODE_1_13_0_0(DataOutput out,

Review comment:
       Since creation of 1.13 release is ongoing, I assume that this will go in 1.14 release. Do we need to update this method to toDataPre_GEODE_1_14_0_0

##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -725,6 +748,18 @@ protected void serializeKey(DataOutput out,
   @Override
   public void fromData(DataInput in,
       DeserializationContext context) throws IOException, ClassNotFoundException {
+    fromDataPre_GEODE_1_13_0_0(in, context);
+    if (version >= Version.GEODE_1_13_0.ordinal()) {
+      boolean hasTransaction = DataSerializer.readBoolean(in);
+      if (hasTransaction) {
+        this.isLastEventInTransaction = DataSerializer.readBoolean(in);
+        this.transactionId = context.getDeserializer().readObject(in);
+      }
+    }
+  }
+
+  public void fromDataPre_GEODE_1_13_0_0(DataInput in, DeserializationContext context)

Review comment:
       Same comment as above. Do we need to update this method to fromDataPre_GEODE_1_14_0_0?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org