You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/09/29 04:22:15 UTC

[GitHub] [hbase] virajjasani commented on a diff in pull request #4806: HBASE-27398 Remove dumping of EOFException while reading WAL with ProtobufLogReader

virajjasani commented on code in PR #4806:
URL: https://github.com/apache/hbase/pull/4806#discussion_r983050141


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java:
##########
@@ -446,7 +444,7 @@ protected boolean readNext(Entry entry) throws IOException {
         // Else restore our position to original location in hope that next time through we will
         // read successfully.
         LOG.debug("Encountered a malformed edit, seeking back to last good position in file, "
-          + "from {} to {}", inputStream.getPos(), originalPosition, eof);
+          + "from {} to {}", inputStream.getPos(), originalPosition);

Review Comment:
   @Apache9 how about this change (line 447)? This change can be done if not the one above where we are throwing EOF (line 430-431)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org