You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/04/29 06:47:50 UTC
[GitHub] [hbase] GeorryHuang commented on a change in pull request #3182: HBASE-25790 NamedQueue 'BalancerRejection' for recent history of balancer skipping
GeorryHuang commented on a change in pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#discussion_r622770226
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -4220,6 +4229,12 @@ private void getProcedureResult(long procId, CompletableFuture<Void> future, int
"Balancer Decision logs are not maintained by HRegionServer");
}
return getBalancerDecisions(limit);
Review comment:
Okey
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerRejection.java
##########
@@ -0,0 +1,117 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.hadoop.hbase.util.GsonUtil;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+import org.apache.hbase.thirdparty.com.google.gson.Gson;
+import org.apache.hbase.thirdparty.com.google.gson.JsonSerializer;
+
+/**
+ * History of detail information that balancer movements was rejected
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+final public class BalancerRejection extends LogEntry {
+ //The reason why balancer was rejected
+ private final String reason;
+ private final List<String> costFuncInfoList;
+
+ // used to convert object to pretty printed format
+ // used by toJsonPrettyPrint()
+ private static final Gson GSON = GsonUtil.createGson()
+ .setPrettyPrinting()
+ .disableHtmlEscaping()
+ .registerTypeAdapter(BalancerRejection.class, (JsonSerializer<BalancerRejection>)
+ (balancerRejection, type, jsonSerializationContext) -> {
+ Gson gson = new Gson();
+ return gson.toJsonTree(balancerRejection);
+ }).create();
+
+ private BalancerRejection(String reason, List<String> costFuncInfoList) {
+ this.reason = reason;
+ if(costFuncInfoList == null){
+ this.costFuncInfoList = Collections.emptyList();
+ }
+ else {
+ this.costFuncInfoList = costFuncInfoList;
+ }
+ }
+
+ public String getReason() {
+ return reason;
+ }
+
+ public List<String> getCostFuncInfoList() {
+ return costFuncInfoList;
+ }
+
+ @Override
+ public String toString() {
+ return new ToStringBuilder(this)
+ .append("reason", reason)
+ .append("costFuncInfoList", costFuncInfoList.toString())
+ .toString();
+ }
+
+ @Override
+ public String toJsonPrettyPrint() {
+ return GSON.toJson(this);
+ }
+
+ public static class Builder {
+ private String reason;
+ private List<String> costFuncInfoList;
+
+ public Builder setReason(String reason) {
+ this.reason = reason;
+ return this;
+ }
+
+ public Builder addCostFuncInfo(String funcName, double cost, float multiplier){
Review comment:
Okey
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -351,6 +364,21 @@ protected boolean needsBalance(TableName tableName, BalancerClusterState cluster
boolean balanced = total <= 0 || sumMultiplier <= 0 ||
(sumMultiplier > 0 && (total / sumMultiplier) < minCostNeedBalance);
+ if(balanced && isBalancerRejectionRecording){
+ String reason;
+ if (total <= 0) {
+ reason = "(cost1*multiplier1)+(cost2*multiplier2)+...+(costn*multipliern) = " + total + " <= 0";
+ } else if (sumMultiplier <= 0) {
+ reason = "sumMultiplier = " + sumMultiplier + " <= 0";
+ } else if ((total / sumMultiplier) < minCostNeedBalance) {
+ reason =
+ "[(cost1*multiplier1)+(cost2*multiplier2)+...+(costn*multipliern)]/sumMultiplier = " + (total
+ / sumMultiplier) + " <= minCostNeedBalance(" + minCostNeedBalance + ")";
+ } else {
+ reason = "Unknown reason, please check the code for bugs";
Review comment:
Right! This else is unnecessary
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/impl/BalancerRejectionQueueService.java
##########
@@ -0,0 +1,138 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.namequeues.impl;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.BalancerRejection;
+import org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer;
+import org.apache.hadoop.hbase.namequeues.BalancerRejectionDetails;
+import org.apache.hadoop.hbase.namequeues.BalancerRejectionDetails;
+import org.apache.hadoop.hbase.namequeues.NamedQueuePayload;
+import org.apache.hadoop.hbase.namequeues.NamedQueueService;
+import org.apache.hadoop.hbase.namequeues.request.NamedQueueGetRequest;
+import org.apache.hadoop.hbase.namequeues.response.NamedQueueGetResponse;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.RecentLogs;
+import org.apache.hadoop.hbase.util.GsonUtil;
+import org.apache.hbase.thirdparty.com.google.common.collect.EvictingQueue;
+import org.apache.hbase.thirdparty.com.google.common.collect.Lists;
+import org.apache.hbase.thirdparty.com.google.common.collect.Queues;
+import org.apache.hbase.thirdparty.com.google.gson.Gson;
+import org.apache.hbase.thirdparty.com.google.gson.JsonSerializer;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Queue;
+import java.util.stream.Collectors;
Review comment:
Will remove unused imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org